From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-hackers@lists.postgresql.org
Subject: Putting kerberos/ldap logs somewhere useful
Date: Mon, 05 Aug 2019 19:26:45 -0400
Message-ID: <16017.1565047605@sss.pgh.pa.us> (raw)
I got frustrated just now because this:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2019-08-05%2021%3A18%3A23
is essentially undebuggable, thanks to the buildfarm's failure to
capture any error output from slapd. That's not the buildfarm
script's fault: it's willing to capture everything placed in the
agreed-on log directory. But the TAP test script randomly places
the daemon's log file somewhere else, one level up. The kerberos
test script has the same problem.
Hence, I propose the attached. This just moves the actual log
files ... we could possibly move the daemons' .conf files as well,
but I think they're probably not variable enough to be interesting.
regards, tom lane
Attachments:
[text/x-diff] put-krb-and-ldap-logs-somewhere-useful.patch (1.3K, ../16017.1565047605@sss.pgh.pa.us/2-put-krb-and-ldap-logs-somewhere-useful.patch)
download | inline diff:diff --git a/src/test/kerberos/t/001_auth.pl b/src/test/kerberos/t/001_auth.plindex 34845a7..e3eb052 100644--- a/src/test/kerberos/t/001_auth.pl+++ b/src/test/kerberos/t/001_auth.pl@@ -67,8 +67,8 @@ my $realm = 'EXAMPLE.COM';
my $krb5_conf = "${TestLib::tmp_check}/krb5.conf";
my $kdc_conf = "${TestLib::tmp_check}/kdc.conf";
-my $krb5_log = "${TestLib::tmp_check}/krb5libs.log";-my $kdc_log = "${TestLib::tmp_check}/krb5kdc.log";+my $krb5_log = "${TestLib::log_path}/krb5libs.log";+my $kdc_log = "${TestLib::log_path}/krb5kdc.log";
my $kdc_port = get_free_port();
my $kdc_datadir = "${TestLib::tmp_check}/krb5kdc";
my $kdc_pidfile = "${TestLib::tmp_check}/krb5kdc.pid";
diff --git a/src/test/ldap/t/001_auth.pl b/src/test/ldap/t/001_auth.plindex 47bc090..5efb87a 100644--- a/src/test/ldap/t/001_auth.pl+++ b/src/test/ldap/t/001_auth.pl@@ -52,7 +52,7 @@ my $ldap_datadir = "${TestLib::tmp_check}/openldap-data";
my $slapd_certs = "${TestLib::tmp_check}/slapd-certs";
my $slapd_conf = "${TestLib::tmp_check}/slapd.conf";
my $slapd_pidfile = "${TestLib::tmp_check}/slapd.pid";
-my $slapd_logfile = "${TestLib::tmp_check}/slapd.log";+my $slapd_logfile = "${TestLib::log_path}/slapd.log";
my $ldap_conf = "${TestLib::tmp_check}/ldap.conf";
my $ldap_server = 'localhost';
my $ldap_port = get_free_port();
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
Subject: Re: Putting kerberos/ldap logs somewhere useful
In-Reply-To: <16017.1565047605@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox