From: Anastasia Lubennikova <a.lubennikova@postgrespro.ru>
To: pgsql-hackers@lists.postgresql.org
Cc: Justin Pryzby <justin@telsasoft.com>
Subject: Re: bitmaps and correlation
Date: Fri, 06 Nov 2020 13:51:26 +0000
Message-ID: <160467068611.7362.8226463259534237605.pgcf@coridan.postgresql.org> (raw)
In-Reply-To: <20200313140916.GP29065@telsasoft.com>
References: <20190101225615.GF25379@telsasoft.com>
<20200313140916.GP29065@telsasoft.com>
Status update for a commitfest entry
According to cfbot, the patch fails to apply. Could you please send a rebased version?
I wonder why this patch hangs so long without a review. Maybe it will help to move discussion forward, if you provide more examples of queries that can benefit from this imporovement?
The first patch is simply a refactoring and don't see any possible objections against it.
The second patch also looks fine to me. The logic is understandable and the code is neat.
It wouldn't hurt to add a comment for this computation, though.
+ pages_fetched = pages_fetchedMAX + indexCorrelation*indexCorrelation*(pages_fetchedMIN - pages_fetchedMAX);
The new status of this patch is: Waiting on Author
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: a.lubennikova@postgrespro.ru, pgsql-hackers@lists.postgresql.org, justin@telsasoft.com
Subject: Re: bitmaps and correlation
In-Reply-To: <160467068611.7362.8226463259534237605.pgcf@coridan.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox