From: Cary Huang <cary.huang@highgo.ca>
To: pgsql-hackers@lists.postgresql.org
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Subject: Re: pg_rewind copies
Date: Tue, 15 Dec 2020 22:08:50 +0000
Message-ID: <160807013024.1158.705820212542993455.pgcf@coridan.postgresql.org> (raw)
In-Reply-To: <f67feb24-5833-88cb-1020-19a4a2b83ac7@iki.fi>
References: <f67feb24-5833-88cb-1020-19a4a2b83ac7@iki.fi>
<f67feb24-5833-88cb-1020-19a4a2b83ac7@iki.fi>
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation: not tested
Hello
The patch seems to do as described and the regression and tap tests are passing
+ /*
+ * A local source is not expected to change while we're rewinding, so check
+ * that we size of the file matches our earlier expectation.
+ */
Is this a tyoo?
thanks
Cary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: cary.huang@highgo.ca, pgsql-hackers@lists.postgresql.org, hlinnaka@iki.fi
Subject: Re: pg_rewind copies
In-Reply-To: <160807013024.1158.705820212542993455.pgcf@coridan.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox