pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Matthew Stickney <mtstickney@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: [PATCH] (Windows) psql echoes password when reading from pipe
Date: Wed, 23 May 2018 19:06:29 -0400
Message-ID: <16097.1527116789@sss.pgh.pa.us> (raw)
In-Reply-To: <c3d315f2-c1dc-18ce-29fa-7919dace540e@gmail.com>
References: <502a1fff-862b-da52-1031-f68df6ed5a2d@gmail.com>
	<14853.1527015354@sss.pgh.pa.us>
	<CAKH_Ld7A=3dFAvUFN1hFq-67=Ronx3Aq-muDhFKh4iHu3MMk6Q@mail.gmail.com>
	<18079.1527019746@sss.pgh.pa.us>
	<CAKH_Ld4j51U+k9_MHoA=HCx5=PP5i=6US7Lyum-2xXxAPZFG5A@mail.gmail.com>
	<23826.1527027253@sss.pgh.pa.us>
	<c3d315f2-c1dc-18ce-29fa-7919dace540e@gmail.com>

Matthew Stickney <mtstickney@gmail.com> writes:
> The attached is a patch that uses the _fileno/_get_osfhandle approach. 
> This doesn't address the stdin fallback, or error handling if opening 
> termin fails; however, it should be no worse than what's there now, and 
> it fixes the immediate problem.

LGTM; pushed with some cosmetic changes.

> I'm still thinking about the fallback in terms of a mintty-type 
> environment, but I wanted to get this patch out there in the meantime.

Yeah.  I'm not absolutely sure that we need to do anything there,
given the lack of field complaints; but if we can think of a simple
way to make it more bulletproof, all the better.

			regards, tom lane




view thread (9+ messages)

Message-ID: <16097.1527116789@sss.pgh.pa.us>
Permalink:  ../16097.1527116789@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/16097.1527116789@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, mtstickney@gmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: [PATCH] (Windows) psql echoes password when reading from pipe
  In-Reply-To: <16097.1527116789@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox