pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: REINDEX INDEX results in a crash for an index of pg_class since 9.6
Date: Tue, 30 Apr 2019 14:41:00 -0400
Message-ID: <16277.1556649660@sss.pgh.pa.us> (raw)
In-Reply-To: <20190430182741.s6o7mo5ebmgxxi5x@alap3.anarazel.de>
References: <12189.1556575627@sss.pgh.pa.us>
	<20190429220924.lfptluzkujb26y2n@alap3.anarazel.de>
	<20190430030342.jmbgnih4q3cdoufz@alap3.anarazel.de>
	<26051.1556599053@sss.pgh.pa.us>
	<BC406D10-146C-4495-AC5E-492CADBFA144@anarazel.de>
	<26528.1556599820@sss.pgh.pa.us>
	<20190430070552.jzqgcy4ihalx7nur@alap3.anarazel.de>
	<30579.1556639470@sss.pgh.pa.us>
	<20190430173457.pg6i6urvevse5jer@alap3.anarazel.de>
	<29546.1556647550@sss.pgh.pa.us>
	<20190430182741.s6o7mo5ebmgxxi5x@alap3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> On 2019-04-30 14:05:50 -0400, Tom Lane wrote:
>> Possibly we could run them in a TAP test that configures a cluster
>> with autovac disabled?

> Hm. Would it be sufficient to instead move them to a non-concurrent
> test group, and stick a BEGIN; LOCK pg_class, ....; COMMIT; around it?

Doubt it.  Maybe you could get away with it given that autovacuum and
autoanalyze only do non-transactional updates to pg_class, but that
seems like a pretty shaky assumption.

> This is a pretty finnicky area of the code, with obviously not enough
> test coverage.  I'm inclined to remove them from the back branches, and
> try to get them working in master?

I think trying to get this "working" is a v13 task now.  We've obviously
never tried to stress the case before, so you're neither fixing a
regression nor fixing a new-in-v12 issue.

			regards, tom lane





view thread (82+ messages)  latest in thread

Message-ID: <16277.1556649660@sss.pgh.pa.us>
Permalink:  ../16277.1556649660@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/16277.1556649660@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, michael@paquier.xyz, pgsql-hackers@lists.postgresql.org
  Subject: Re: REINDEX INDEX results in a crash for an index of pg_class since 9.6
  In-Reply-To: <16277.1556649660@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox