From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Petr Jelinek <petr.jelinek@2ndquadrant.com>
Cc: Petr Jelinek <petr@2ndquadrant.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: John Gorman <johngorman2@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: PATCH: two slab-like memory allocators
Date: Mon, 27 Feb 2017 17:56:08 +0100
Message-ID: <1632374b-7ef6-0105-0fdc-d750987dc272@2ndquadrant.com> (raw)
In-Reply-To: <20170227164828.akgzeg6ggl2v4x7s@alap3.anarazel.de>
References: <20170211013337.iw32bvfqwta634wy@alap3.anarazel.de>
<53def906-2197-bc06-b987-d237f9574800@2ndquadrant.com>
<20170214022221.obhdeyfn34h6hkwj@alap3.anarazel.de>
<19464ac8-e66b-3598-858f-29c749bec35a@2ndquadrant.com>
<b3b2245c-b37a-e1e5-ebc4-857c914bc747@2ndquadrant.com>
<20170224221038.43xf2cyonczzr6hb@alap3.anarazel.de>
<20170227111732.vrx5v72ighehwpkf@alap3.anarazel.de>
<20170227120200.5jc3ubg5jrqaznd7@alap3.anarazel.de>
<26061.1488209545@sss.pgh.pa.us>
<20170227155532.o7casczq5parlmz4@alap3.anarazel.de>
<20170227164828.akgzeg6ggl2v4x7s@alap3.anarazel.de>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
On 02/27/2017 05:48 PM, Andres Freund wrote:
> On 2017-02-27 07:55:32 -0800, Andres Freund wrote:
>> On 2017-02-27 10:32:25 -0500, Tom Lane wrote:
>>> Andres Freund <andres@anarazel.de> writes:
>>>> And pushed slab and its usage. Will have a look at generation.c
>>>> tomorrow.
>>>
>>> Perhaps first you need to find out why so much of the buildfarm
>>> is unhappy.
>>
>> Will do, after a morning coffee.
>
> Hm. Not entirely clear on what's going on yet. I've run the tests on
> hydra (community ppc 64 machine), which is pretty similar to termite
> which failed [1] with:
> TRAP: BadArgument("!(((context) != ((void *)0) && (((((const Node*)((context)))->type) == T_AllocSetContext) || ((((const Node*)((context)))->type) == T_SlabContext))))", File: "/home/pgbuildfarm/buildroot-termite/HEAD/pgsql.build/../pgsql/src/backend/utils/mmgr/mcxt.c", Line: 1010)
>
> The best theory I have so far that I have is that slab.c's idea of
> StandardChunkHeader's size doesn't match what mcxt.c think it is
> (because slab.c simply embeds StandardChunkHeader, but mcxt uses
> MAXALIGN(sizeof(StandardChunkHeader))). That's not good, but I don't
> quite see how that'd cause the issue, since StandardChunkHeader's size
> should always be properly sized.
>
> Tomas, do you have access to termite (which appears to be run by Craig,
> under company mail).
>
No, I don't, but I'll ping Craig. I might ping him, but it's ~4AM in
Australia, though, so it'll take time.
FWIW I think the ppc64 machines are failing because of unrelated issue
(changes to integer timestamps). We should probably look at 32bit
machines first.
regards
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tomas.vondra@2ndquadrant.com, andres@anarazel.de, tgl@sss.pgh.pa.us, petr.jelinek@2ndquadrant.com, petr@2ndquadrant.com, robertmhaas@gmail.com, johngorman2@gmail.com
Subject: Re: PATCH: two slab-like memory allocators
In-Reply-To: <1632374b-7ef6-0105-0fdc-d750987dc272@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox