pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Aleksander Alekseev <aleksander@timescale.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Cc: Himanshu Upadhyaya <upadhyaya.himanshu@gmail.com>
Cc: Mark Dilger <mark.dilger@enterprisedb.com>
Cc: Andres Freund <andres@anarazel.de>
Subject: Re: HOT chain validation in verify_heapam()
Date: Wed, 22 Mar 2023 15:27:01 -0400
Message-ID: <1650745.1679513221@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+TgmoZub-bCg=ORmbcCCbteQ2UQUc14T2GK+v+6-VLd-8yK4g@mail.gmail.com>
References: <CA+Tgmoas7DOU9umrrvhZO1VMUc74eQsyKkeVEKeZZD4ODBLH8w@mail.gmail.com>
	<CAPF61jBjb+VafRhsmRg2gN1mX89+iPyPrfa6ZdUVtoX7T35TOg@mail.gmail.com>
	<CAJ7c6TNd8xPKGF-kja40PVGDrfg1WEVomi_mctxNFGWx=vFz6g@mail.gmail.com>
	<CAPF61jD6zewYmYY88hq5XYzW1bAuRBYChnRYGuCQ7cAZ9C3vPA@mail.gmail.com>
	<CAJ7c6TNFGab8HGzngcgPh=eiWP+VgD-TKEwT7SWC5Hnqu8KmRg@mail.gmail.com>
	<CAPF61jCJrHfSniWNrPXoyZT8Pe9gVfuPNt3c6_dURBZjUKED7A@mail.gmail.com>
	<CA+TgmoYD-mx2=2KhW8815p1rU=2Ftndn2O4UEk87JbPN7qrwtQ@mail.gmail.com>
	<CAPF61jDNh3-pGpKuAJ5FN73A8oDoN8iOi3vGU_DY4RP9txdcqQ@mail.gmail.com>
	<20221109220803.t25sosmfvkeglhy4@awork3.anarazel.de>
	<CAPF61jCfHvhoaiYhmD3DHP_LGnzVo5qbAYefb3BVHnShFTG32A@mail.gmail.com>
	<20221202001321.igy24zwq7myyfi4o@awork3.anarazel.de>
	<CAPF61jB67rwtNdaBbTURtHkbqwn1gQTZVWx7KUe6sqT83Fg1Wg@mail.gmail.com>
	<CAJ7c6TO8GN4qG-M6xk-T-njUO4-=iufykoznCqgRv9RUe0Eg9g@mail.gmail.com>
	<CA+TgmoYuOHg8ijjYZk7VtvxyYr0Sp0ZeJRguoDOsFhhWnxuHdA@mail.gmail.com>
	<CAPF61jCNEZCmM51YRL+N2MiYSnE+Sj11DPjELkeO5! 7awU8PNaw@mail.gmail.com>
	<CAPF61jArDKa3QHhunH=wR__qAghy5gOAJoFyvXuTSwhcj5gG9A@mail.gmail.com>
	<CA+TgmoYNqimmA0ziZVQhwcUSx2+bWOuvtg0LwR8=3_tSg7abyg@mail.gmail.com>
	<CAPF61jDKLeQe2v5xg8S8BZvu3f+YBoXKx26brq3_aqkCEHEkYg@mail.gmail.com>
	<CA+TgmoY8WUSjwpM8OxwK7meDq0mHpkbXrr+iver1WpZXu_43jA@mail.gmail.com>
	<CAPF61jBgonN=1Tmk6WXmBNnrNCPXS_kdSzZ4H4hQTu1JK9VMHA@mail.gmail.com>
	<CA+TgmoYRMJX6UE9zjeRKUYgnTrtLOayOcg3im2pGQYCgwDpNog@mail.gmail.com>
	<CA+TgmoYsHKB4kx7LSQUTHeBY5i2bBmMt3xLyYgjPbLzPZRdqiQ@mail.gmail.com>
	<CA491701-7A8A-4167-A43E-D3A9A2C34371@enterprisedb.com>
	<CAJ7c6TP5CJOkNfM5=Qt4+YmiryL0_UCYtw0LRXr6HcUJ956KTg@mail.gmail.com>
	<CA+TgmoZoF5ctr=8GtyJQ6yyAn5h05gduR9Ue=9BKyq-UG1HYxw@mail.gmail.com>
	<CAPF61jAtC-GuMakGHPE8jAQt2DoYU7sWinwOMBYNC+wa5iYP=w@mail.gmail.com>
	<CAPF61jCar6CoQKZAL95K6ae=xUCOFKdGq+AxoO8T9628v7xoSw@mail.gmail.com>
	<CAJ7c6TMtmtXy1Du54p77=ychkqen8e=NP829EO21hRe=ftZVDQ@mail.gmail.com>
	<CA+TgmoZub-bCg=ORmbcCCbteQ2UQUc14T2GK+v+6-VLd-8yK4g@mail.gmail.com>

Robert Haas <robertmhaas@gmail.com> writes:
> I have committed this after tidying up a bunch of things in the test
> case file that I found too difficult to understand -- or in some cases
> just incorrect, like:

My animal mamba doesn't like this one bit.

I suspect the reason is that it's big-endian (PPC) and the endianness
hacking in the test is simply wrong:

        syswrite($file,
                 pack("L", $ENDIANNESS eq 'little' ? 0x00010019 : 0x19000100))
            or BAIL_OUT("syswrite failed: $!");

pack's L code should already be performing an endianness swap, so why
are we doing another one in the argument?

			regards, tom lane





view thread (100+ messages)  latest in thread

Message-ID: <1650745.1679513221@sss.pgh.pa.us>
Permalink:  ../1650745.1679513221@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1650745.1679513221@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com, aleksander@timescale.com, upadhyaya.himanshu@gmail.com, mark.dilger@enterprisedb.com, andres@anarazel.de
  Subject: Re: HOT chain validation in verify_heapam()
  In-Reply-To: <1650745.1679513221@sss.pgh.pa.us>
  References: <CA+Tgmoas7DOU9umrrvhZO1VMUc74eQsyKkeVEKeZZD4ODBLH8w@mail.gmail.com> <CAPF61jDKLeQe2v5xg8S8BZvu3f+YBoXKx26brq3_aqkCEHEkYg@mail.gmail.com> <CA+TgmoY8WUSjwpM8OxwK7meDq0mHpkbXrr+iver1WpZXu_43jA@mail.gmail.com> <CAPF61jBgonN=1Tmk6WXmBNnrNCPXS_kdSzZ4H4hQTu1JK9VMHA@mail.gmail.com> <CA+TgmoYRMJX6UE9zjeRKUYgnTrtLOayOcg3im2pGQYCgwDpNog@mail.gmail.com> <CA+TgmoYsHKB4kx7LSQUTHeBY5i2bBmMt3xLyYgjPbLzPZRdqiQ@mail.gmail.com> <CA491701-7A8A-4167-A43E-D3A9A2C34371@enterprisedb.com> <CAJ7c6TP5CJOkNfM5=Qt4+YmiryL0_UCYtw0LRXr6HcUJ956KTg@mail.gmail.com> <CA+TgmoZoF5ctr=8GtyJQ6yyAn5h05gduR9Ue=9BKyq-UG1HYxw@mail.gmail.com> <CAPF61jAtC-GuMakGHPE8jAQt2DoYU7sWinwOMBYNC+wa5iYP=w@mail.gmail.com> <CAPF61jCar6CoQKZAL95K6ae=xUCOFKdGq+AxoO8T9628v7xoSw@mail.gmail.com> <CAJ7c6TMtmtXy1Du54p77=ychkqen8e=NP829EO21hRe=ftZVDQ@mail.gmail.com> <CA+TgmoZub-bCg=ORmbcCCbteQ2UQUc14T2GK+v+6-VLd-8yK4g@mail.gmail.com> <1650745.1679513221@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox