From: Tom Lane <tgl@sss.pgh.pa.us>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Add an optional timeout clause to isolationtester step.
Date: Sat, 07 Mar 2020 16:23:58 -0500
Message-ID: <16530.1583616238@sss.pgh.pa.us> (raw)
In-Reply-To: <20200307211709.6kfpiddif4uxafg5@nol>
References: <20200303092551.GB1890@paquier.xyz>
<20200304051510.GE2593@paquier.xyz>
<CAOBaU_Z=qkE42VQ25mps+zyAz+WUn3wZoev4uhGW+gAXBBS2YA@mail.gmail.com>
<20200305035354.GQ2593@paquier.xyz>
<20200306131547.GA2904@nol>
<20200307014142.GC1531@paquier.xyz>
<20200307061615.c47sju2bytuiaazv@nol>
<8441.1583595994@sss.pgh.pa.us>
<20200307205328.ffidfyo3me46qscn@nol>
<15903.1583615371@sss.pgh.pa.us>
<20200307211709.6kfpiddif4uxafg5@nol>
Julien Rouhaud <rjuju123@gmail.com> writes:
> On Sat, Mar 07, 2020 at 04:09:31PM -0500, Tom Lane wrote:
>> Julien Rouhaud <rjuju123@gmail.com> writes:
>>> On Sat, Mar 07, 2020 at 10:46:34AM -0500, Tom Lane wrote:
>>>> What's the actual need that you're trying to deal with?
>>> Testing the correct behavior of non trivial commands, such as CIC/reindex
>>> concurrently, that fails during the execution.
>> Hmm ... don't see how a timeout helps with that?
> For reindex concurrently, a SELECT FOR UPDATE on a different connection can
> ensure that the reindex will be stuck at some point, so canceling the command
> after a long enough timeout reproduces the original faulty behavior.
Hmm, seems like a pretty arbitrary (and slow) way to test that. I'd
envision testing that by setting up a case with an expression index
where the expression is designed to fail at some point partway through
the build -- say, with a divide-by-zero triggered by one of the tuples
to be indexed.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, rjuju123@gmail.com, michael@paquier.xyz
Subject: Re: Add an optional timeout clause to isolationtester step.
In-Reply-To: <16530.1583616238@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox