From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-hackers@lists.postgresql.org
Subject: Re: Subscription tests fail under CLOBBER_CACHE_ALWAYS
Date: Fri, 21 May 2021 18:14:19 -0400
Message-ID: <165922.1621635259@sss.pgh.pa.us> (raw)
In-Reply-To: <3382681.1621381328@sss.pgh.pa.us>
References: <3382681.1621381328@sss.pgh.pa.us>
I wrote:
> I count three distinct bugs that were exposed by this attempt:
> ...
> 2. Said bug causes a segfault in the apply worker process.
> This causes the parent postmaster to give up and die.
> I don't understand why we don't treat that like a crash
> in a regular backend, considering that an apply worker
> is running largely user-defined code.
Figured that one out: we *do* treat it like a crash in a regular
backend, which explains the lack of field complaints. What's
contributing to the TAP test getting stuck is that PostgresNode.pm
does this:
open my $conf, '>>', "$pgdata/postgresql.conf";
print $conf "\n# Added by PostgresNode.pm\n";
...
print $conf "restart_after_crash = off\n";
So that'd be fine, if only the TAP tests were a bit more robust
about postmasters disappearing unexpectedly.
BTW, I wonder whether it wouldn't be a good idea for the
postmaster to log something along the lines of "stopping
because restart_after_crash is off". The present behavior
can be quite mysterious otherwise (it certainly confused me).
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
Subject: Re: Subscription tests fail under CLOBBER_CACHE_ALWAYS
In-Reply-To: <165922.1621635259@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox