From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Craig Ringer <craig.ringer@enterprisedb.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Subject: Re: 011_crash_recovery.pl intermittently fails
Date: Sun, 07 Mar 2021 20:09:33 -0500
Message-ID: <1690207.1615165773@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+hUKGL0AGqWC4Gst0teSqVK2RcYx6vPbnfSoVeKE7ppADTdcA@mail.gmail.com>
References: <20210305.165117.1192284154251506643.horikyota.ntt@gmail.com>
<20210305.180819.844001367516475145.horikyota.ntt@gmail.com>
<1495174.1614961015@sss.pgh.pa.us>
<20210308.093915.2235769710275045679.horikyota.ntt@gmail.com>
<CA+hUKGL0AGqWC4Gst0teSqVK2RcYx6vPbnfSoVeKE7ppADTdcA@mail.gmail.com>
Thomas Munro <thomas.munro@gmail.com> writes:
> Thanks! I'm afraid I wouldn't get around to it for a few weeks, so if
> you have time, please do. (I'm not sure if it's strictly necessary to
> log *this* xid, if a higher xid has already been logged, considering
> that the goal is just to avoid getting confused about an xid that is
> recycled after crash recovery, but coordinating that might be more
> complicated; I don't know.)
Yeah, ideally the patch wouldn't add any unnecessary WAL flush,
if there's some cheap way to determine that our XID must already
have been written out. But I'm not sure that it's worth adding
any great amount of complexity to avoid that. For sure I would
not advocate adding any new bookkeeping overhead in the mainline
code paths to support it.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, thomas.munro@gmail.com, horikyota.ntt@gmail.com, pg@bowt.ie, pgsql-hackers@lists.postgresql.org, craig.ringer@enterprisedb.com, robertmhaas@gmail.com
Subject: Re: 011_crash_recovery.pl intermittently fails
In-Reply-To: <1690207.1615165773@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox