From: Tom Lane <tgl@sss.pgh.pa.us>
To: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Mark Dilger <hornschnorter@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Missing dependency tracking for TableFunc nodes
Date: Thu, 14 Nov 2019 17:35:06 -0500
Message-ID: <17008.1573770906@sss.pgh.pa.us> (raw)
In-Reply-To: <20191114222232.o76u6jdvf53ozjjk@development>
References: <18427.1573508501@sss.pgh.pa.us>
<997cbcae-7739-f871-84a0-1192380abb54@gmail.com>
<15228.1573695479@sss.pgh.pa.us>
<20191114213124.i6xwx24y26iklzds@development>
<14155.1573767414@sss.pgh.pa.us>
<20191114222232.o76u6jdvf53ozjjk@development>
Tomas Vondra <tomas.vondra@2ndquadrant.com> writes:
> On Thu, Nov 14, 2019 at 04:36:54PM -0500, Tom Lane wrote:
>> Hm. No, it's not enough, unless you add more logic to deal with the
>> possibility that the stats object is gone by the time you have the
>> table lock. Consider e.g. two concurrent DROP STATISTICS commands,
>> or a statistics drop that's cascading from something like a drop
>> of a relevant function and so has no earlier table lock.
> Isn't that solved by RemoveObjects() doing this?
> /* Get an ObjectAddress for the object. */
> address = get_object_address(stmt->removeType,
> object,
> &relation,
> AccessExclusiveLock,
> stmt->missing_ok);
Ah, I see, we already have AEL on the stats object itself. So that
eliminates my concern about a race between two RemoveStatisticsById
calls, but what we have instead is fear of deadlock. A DROP STATISTICS
command will acquire AEL on the stats object but then AEL on the table,
the opposite of what will happen during DROP TABLE, so concurrent
executions of those will deadlock. That might be better than the
failures Mark is seeing now, but not by much.
A correct fix I think is that the planner ought to acquire AccessShareLock
on a stats object it's trying to use (and then recheck whether the object
is still there). That seems rather expensive, but there may be no other
way.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, tomas.vondra@2ndquadrant.com, hornschnorter@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Missing dependency tracking for TableFunc nodes
In-Reply-To: <17008.1573770906@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox