pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Andrew Dunstan <andrew@dunslane.net>
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: enable certain TAP tests for MSVC builds
Date: Sun, 5 Dec 2021 11:57:31 -0500
Message-ID: <17093da5-e40d-8335-d53a-2bd803fc38b0@dunslane.net> (raw)


Certain TAP tests rely on settings that the Make files provide for them.
However vcregress.pl doesn't provide those settings. This patch remedies
that, and I propose to apply it shortly (when we have a fix for the SSL
tests that I will write about separately) and backpatch it appropriately.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

Attachments:

  [text/x-patch] vcregress-settings.patch (725B, ../17093da5-e40d-8335-d53a-2bd803fc38b0@dunslane.net/2-vcregress-settings.patch)
  download | inline diff:
diff --git a/src/tools/msvc/vcregress.pl b/src/tools/msvc/vcregress.pl
index f3357b3292..608b0449a3 100644
--- a/src/tools/msvc/vcregress.pl
+++ b/src/tools/msvc/vcregress.pl
@@ -59,6 +59,12 @@ copy("$Config/autoinc/autoinc.dll",               "src/test/regress");
 copy("$Config/regress/regress.dll",               "src/test/regress");
 copy("$Config/dummy_seclabel/dummy_seclabel.dll", "src/test/regress");
 
+# Settings used by TAP tests
+$ENV{with_ssl} = $config->{openssl} ? 'openssl' : 'no';
+$ENV{with_ldap} = $config->{ldap} ? 'yes' : 'no';
+$ENV{with_icu} = $config->{icu} ? 'yes' : 'no';
+$ENV{with_gssapi} = $config->{gss} ? 'yes' : 'no';
+
 $ENV{PATH} = "$topdir/$Config/libpq;$ENV{PATH}";
 
 if ($ENV{PERL5LIB})

view thread (7+ messages)  latest in thread

Message-ID: <17093da5-e40d-8335-d53a-2bd803fc38b0@dunslane.net>
Permalink:  ../17093da5-e40d-8335-d53a-2bd803fc38b0@dunslane.net/
Also on:    postgresql.org/message-id/17093da5-e40d-8335-d53a-2bd803fc38b0@dunslane.net

copy link · copy postgr.es · copy git am

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: andrew@dunslane.net, pgsql-hackers@lists.postgresql.org
  Subject: Re: enable certain TAP tests for MSVC builds
  In-Reply-To: <17093da5-e40d-8335-d53a-2bd803fc38b0@dunslane.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox