From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Piotr Stefaniak <postgres@piotr-stefaniak.me>
Subject: Re: Emacs vs pg_indent's weird indentation for function declarations
Date: Wed, 15 May 2019 17:30:42 -0400
Message-ID: <17265.1557955842@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+hUKGKb9n8xgWW3uEiA3Txvb9Er-FRX-wAAiiWdAjD7-nN44Q@mail.gmail.com>
References: <CAEepm=0P3FeTXRcU5B2W3jv3PgRVZ-kGUXLGfd42FFhUROO3ug@mail.gmail.com>
<7659.1548653310@sss.pgh.pa.us>
<20190128070842.GF15401@paquier.xyz>
<CAEepm=0UtAPN2RChs7=pOqHm2uvbU6Px7vfyvt8_-eiP7=ozUg@mail.gmail.com>
<CA+hUKGKCvoUsU_HpW+hg8WNDUFjQEgQvVi9AwYdsqgJfV8TzxQ@mail.gmail.com>
<14259.1557895390@sss.pgh.pa.us>
<9170.1557955021@sss.pgh.pa.us>
<CA+hUKGKb9n8xgWW3uEiA3Txvb9Er-FRX-wAAiiWdAjD7-nN44Q@mail.gmail.com>
Thomas Munro <thomas.munro@gmail.com> writes:
> On Thu, May 16, 2019 at 9:17 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> A small problem with the "rejiggering" is that it now makes the wrong
>> choice for K&R-style function definitions, causing them to be weirdly
>> indented. For our purposes, that's a non-problem so I'm not excited
>> about trying to make it smart enough to recognize those. We do have
>> a couple of amazingly old and crufty K&R-style functions in src/port/,
>> though, so probably we'd wish to fix those.
> What kid of fork is pg_bsd_indent... do we care about upstreaming
> changes? I guess someone would need to deal with that case eventually
> if so.
We regard the FreeBSD copy as upstream, and I think we're mostly in sync
with that but only mostly. So it would come down to whether the FreeBSD
maintainer is worried about K&R mode and what he wants to do about that.
Piotr, that's still you isn't it?
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, thomas.munro@gmail.com, michael@paquier.xyz, postgres@piotr-stefaniak.me
Subject: Re: Emacs vs pg_indent's weird indentation for function declarations
In-Reply-To: <17265.1557955842@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox