From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Simon Riggs <simon@2ndquadrant.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Poorly thought out code in vacuum
Date: Fri, 06 Jan 2012 12:24:55 -0500
Message-ID: <17477.1325870695@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+TgmobiR=sNTsknS8F8MNqEp1ftbCZHX_YkWEBDCH5+yfnpdQ@mail.gmail.com>
References: <25422.1325810273@sss.pgh.pa.us>
<CA+TgmoYeYaZfa-oKqpu9Y=+vSdQf=kCcRxq-M30JPX4w+vkSpw@mail.gmail.com>
<CA+U5nM+DZ9jraZ_wCUBqq4+5jpEhrEW13ySpYn40GZmAntM6-Q@mail.gmail.com>
<CA+TgmobzJz9xRiF=At4nEy2DOnu-gXdeyfP1ajM4BNyFPQfVoA@mail.gmail.com>
<CA+U5nM+E8WjQ0DbDogAuRupVny53xvhNcJjAV4cJ51iWKSnFKA@mail.gmail.com>
<CA+TgmobiR=sNTsknS8F8MNqEp1ftbCZHX_YkWEBDCH5+yfnpdQ@mail.gmail.com>
I started to wonder how likely it would be that some other process would
sit on a buffer pin for so long as to allow 134217727 iterations of
ReadBufferExtended, even given the slowdowns associated with
CLOBBER_CACHE_ALWAYS. This led to some fruitless searching for possible
deadlock conditions, but eventually I realized that there's a much
simpler explanation: if PrivateRefCount > 1 then
ConditionalLockBufferForCleanup always fails. This means that once
ConditionalLockBufferForCleanup has failed once, the currently committed
code in lazy_vacuum_heap is guaranteed to loop until it gets a failure
in enlarging the ResourceOwner buffer-reference array. Which in turn
means that neither of you ever actually exercised the skip case, or
you'd have noticed the problem. Nor are the current regression tests
well designed to exercise the case. (There might well be failures of
this type happening from time to time in autovacuum, but we'd not see
any reported failure in the buildfarm, unless we went trawling in
postmaster logs.)
So at this point I've got serious doubts as to the quality of testing of
that whole patch, not just this part.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com, simon@2ndquadrant.com
Subject: Re: Poorly thought out code in vacuum
In-Reply-To: <17477.1325870695@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox