From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: MSVC buildfarm critters are not running modules' TAP tests
Date: Sun, 08 Sep 2019 17:59:00 -0400
Message-ID: <17551.1567979940@sss.pgh.pa.us> (raw)
In-Reply-To: <5e1113b9-e1a6-d68b-c05c-06e607a4cd5f@2ndQuadrant.com>
References: <6628.1567958876@sss.pgh.pa.us>
<5e1113b9-e1a6-d68b-c05c-06e607a4cd5f@2ndQuadrant.com>
Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
> On 9/8/19 12:07 PM, Tom Lane wrote:
>> It looks to me like the reason is that src/tools/msvc/vcregress.pl's
>> subroutine subdircheck isn't considering the possibility that
>> subdirectories of src/test/modules contain TAP tests. The
>> same code is used for contrib, so several existing TAP tests
>> are being missed there too.
> Actually, I think vcregress.pl is OK, this is a gap in the buildfarm
> client's coverage that will be fixed when I make a new release.
Hm. Changing the buildfarm script would be an alternative way to
fix the issue so far as the buildfarm is concerned, but it doesn't
seem like it provides any useful way for one to manually invoke
the tests on Windows. Or am I missing something about how that's
usually done?
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andrew.dunstan@2ndquadrant.com, pgsql-hackers@lists.postgresql.org
Subject: Re: MSVC buildfarm critters are not running modules' TAP tests
In-Reply-To: <17551.1567979940@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox