From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Pavel Borisov <pashkin.elfe@gmail.com>
Cc: Dilip Kumar <dilipbalaut@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: OOM in spgist insert
Date: Thu, 13 May 2021 21:44:07 -0400
Message-ID: <1787101.1620956647@sss.pgh.pa.us> (raw)
In-Reply-To: <1785221.1620954078@sss.pgh.pa.us>
References: <20210513224933.GA20201@alvherre.pgsql>
<1785221.1620954078@sss.pgh.pa.us>
I wrote:
> Anyway, here is a patch set teased apart into committable bites,
> and with your other points addressed.
Oh, maybe some docs would be a good thing too ...
regards, tom lane
Attachments:0004-add-some-docs.patch (text/x-diff, 1.0K) downloaddiff --git a/doc/src/sgml/spgist.sgml b/doc/src/sgml/spgist.sgmlindex cfb2b3c836..18f1f3cdbd 100644--- a/doc/src/sgml/spgist.sgml+++ b/doc/src/sgml/spgist.sgml@@ -978,6 +978,18 @@ LANGUAGE C STRICT;
fails to do that, the <acronym>SP-GiST</acronym> core resorts to
extraordinary measures described in <xref linkend="spgist-all-the-same"/>.
</para>
++ <para>+ When <structfield>longValuesOK</structfield> is true, it is expected+ that successive levels of the <acronym>SP-GiST</acronym> tree will+ absorb more and more information into the prefixes and node labels of+ the inner tuples, making the required leaf datum smaller and smaller,+ so that eventually it will fit on a page.+ To prevent bugs in operator classes from causing infinite insertion+ loops, the <acronym>SP-GiST</acronym> core will raise an error if the+ leaf datum does not become any smaller within ten cycles+ of <function>choose</function> method calls.+ </para>
</sect2>
<sect2 id="spgist-null-labels">
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, alvherre@alvh.no-ip.org, pashkin.elfe@gmail.com, dilipbalaut@gmail.com
Subject: Re: OOM in spgist insert
In-Reply-To: <1787101.1620956647@sss.pgh.pa.us>
References: <20210513224933.GA20201@alvherre.pgsql> <1785221.1620954078@sss.pgh.pa.us> <1787101.1620956647@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox