From: Pierre Forstmann <pierre.forstmann@gmail.com>
To: pgsql-hackers@lists.postgresql.org
Cc: Imran Zaheer <imran.zhir@gmail.com>
Subject: Re: Move system identifier generation to a common helper
Date: Mon, 24 Aug 2026 14:59:45 +0000
Message-ID: <178758358536.1145.1103226781156198059.pgcf@coridan.postgresql.org> (raw)
In-Reply-To: <CA+UBfa=BjJr1PQKSUKNUKniR9HST7+Zk-T-3v2FHQhK6hjshnw@mail.gmail.com>
References: <CA+UBfa=yN+PKPiKPFAryo1AMjwzD+sH28i=_bP7fzZEgSP2kBA@mail.gmail.com>
<CA+UBfa=BjJr1PQKSUKNUKniR9HST7+Zk-T-3v2FHQhK6hjshnw@mail.gmail.com>
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: not tested
Documentation: not tested
Hello,
I have reviewed this patch and it looks good to me.
I have built and tested with both make and meson.
Running make check-world is OK and running with meson:
cd build
meson test -q --print-errorlogs
reports:
Ok: 356
Expected Fail: 0
Fail: 0
Unexpected Pass: 0
Skipped: 35
Timeout: 0
There is no SQL compliance to check and I don't think documentation should be updated.
Regards
PF
The new status of this patch is: Ready for Committer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pierre.forstmann@gmail.com, pgsql-hackers@lists.postgresql.org, imran.zhir@gmail.com
Subject: Re: Move system identifier generation to a common helper
In-Reply-To: <178758358536.1145.1103226781156198059.pgcf@coridan.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox