From: Manu <manuelreyesbravo@gmail.com>
To: Rui Zhao <zhaorui126@gmail.com>
Cc: Amit Langote <amitlangote09@gmail.com>
Cc: Ilmar Yunusov <tanswis42@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: generic plans and "initial" pruning
Date: Wed, 14 Oct 2026 00:59:52 -0300
Message-ID: <179195039214.451044.8981055808666834441@gmail.com> (raw)
In-Reply-To: <CAHWVJhEk4fxnjL9g+zX_wY3bAtAPDcri9fopEV+MW583A4uZvg@mail.gmail.com>
References: <CAHWVJhEk4fxnjL9g+zX_wY3bAtAPDcri9fopEV+MW583A4uZvg@mail.gmail.com>
Hi Rui,
> I've combined Manu's correction and the test in the attached patch,
> which applies on top of v13.
Thanks for folding in the test -- it fails on v13 without the ownership
correction and passes with it, the same as I saw.
cfbot is red only because v13 itself needs a rebase: 1b5dd3a24a4 added an
early return in InitExecPartitionPruneContexts() that conflicts with
v13-0002. The resolution is mechanical -- the lines v13-0002 adds and
removes are unchanged, only the surrounding context moved, and the
patch-ids of v13-0001/0003/0004 and your 0001 are identical before and
after.
On a v13 rebased that way on today's master (0d6103e537e1) with your 0001
on top: make check 239/239, isolation 134/134 and test_plan_advice all
pass. Without the ownership fix, make check fails one test with
"plancache reference ... is not owned by resource owner Portal", so the
fix is still doing its job on current master.
I'm happy to post the rebased series if that's useful; otherwise it's a
one-liner of context for whoever rebases v13.
Regards,
Manu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: manuelreyesbravo@gmail.com, zhaorui126@gmail.com, amitlangote09@gmail.com, tanswis42@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: generic plans and "initial" pruning
In-Reply-To: <179195039214.451044.8981055808666834441@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox