pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Manu <manuelreyesbravo@gmail.com>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Melanie Plageman <melanieplageman@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Assertion failure with temporary relations in single-user mode
Date: Tue, 17 Nov 2026 02:10:24 -0300
Message-ID: <179489222449.37099.6261619082241419378@gmail.com> (raw)
In-Reply-To: <CAHGQGwE0nhCjM53yWZjz8_uYPjSjxbYohvTxkZiWD2U8r6p-Tg@mail.gmail.com>
References: <CAHGQGwE0nhCjM53yWZjz8_uYPjSjxbYohvTxkZiWD2U8r6p-Tg@mail.gmail.com>

Hi Fujii,

On Tue, Nov 17, 2026 at 1:41 PM Fujii Masao
<masao.fujii@gmail.com> wrote:
> I wonder if adding a new TAP test file might be overkill for this fix.

Agreed.  v2, attached, drops it and keeps only the fix in pgstat_io.c,
plus the new row in the stats regression test's list of pg_stat_io
rows.

The code change is the same down to 16.  The stats.out hunk differs
on 18 and 19, and 16 and 17 have no such list; I can post those
versions if they help.

Regards,
Manu

Attachments:

v2-0001-Fix-IO-tracking-of-temporary-relations-in-single-.patch (text/x-patch, 3.4K) download From 513420daf42d8df4542a94d82be963902c2e9fd6 Mon Sep 17 00:00:00 2001 From: Manuel Reyes Bravo <manuelreyesbravo@gmail.com> Date: Mon, 16 Nov 2026 21:16:54 -0300 Subject: [PATCH v2] Fix IO tracking of temporary relations in single-user mode pgstat_tracks_io_object() lists B_STANDALONE_BACKEND among the backend types that never do IO on temporary relations, since 28e626bde00 (v16). A backend in single-user mode executes queries like a client backend, and can create and use temporary tables and sequences. With assertions enabled, an INSERT into a temporary table, CREATE TEMP TABLE AS or nextval() on a temporary sequence fails the assertion in pgstat_count_io_op(): $ echo "CREATE TEMP TABLE t AS SELECT 1;" | postgres --single postgres TRAP: failed Assert("pgstat_tracks_io_op(MyBackendType, io_object, io_context, io_op)") Without assertions, this IO is not counted: pg_stat_io has no "temp relation" row for "standalone backend". Remove B_STANDALONE_BACKEND from this list, and fix the comment above it. The regression test that lists the rows of pg_stat_io gains that row. Discussion: --- src/backend/utils/activity/pgstat_io.c | 14 +++++++------- src/test/regress/expected/stats.out | 3 ++- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/src/backend/utils/activity/pgstat_io.c b/src/backend/utils/activity/pgstat_io.c index 3c8fcb20..cec57596 100644 --- a/src/backend/utils/activity/pgstat_io.c +++ b/src/backend/utils/activity/pgstat_io.c @@ -413,16 +413,16 @@ pgstat_tracks_io_object(BackendType bktype, IOObject io_object, return false; /* - * In core Postgres, only regular backends and WAL Sender processes - * executing queries will use local buffers and operate on temporary - * relations. Parallel workers will not use local buffers (see - * InitLocalBuffers()); however, extensions leveraging background workers - * have no such limitation, so track IO on IOOBJECT_TEMP_RELATION for - * BackendType B_BG_WORKER. + * In core Postgres, only regular backends, WAL Sender processes executing + * queries and standalone backends (single-user mode) will use local + * buffers and operate on temporary relations. Parallel workers will not + * use local buffers (see InitLocalBuffers()); however, extensions + * leveraging background workers have no such limitation, so track IO on + * IOOBJECT_TEMP_RELATION for BackendType B_BG_WORKER. */ no_temp_rel = bktype == B_AUTOVAC_LAUNCHER || bktype == B_BG_WRITER || bktype == B_CHECKPOINTER || bktype == B_AUTOVAC_WORKER || - bktype == B_STANDALONE_BACKEND || bktype == B_STARTUP || + bktype == B_STARTUP || bktype == B_WAL_SUMMARIZER || bktype == B_WAL_WRITER || bktype == B_WAL_RECEIVER; diff --git a/src/test/regress/expected/stats.out b/src/test/regress/expected/stats.out index 8b154712..b1935882 100644 --- a/src/test/regress/expected/stats.out +++ b/src/test/regress/expected/stats.out @@ -81,6 +81,7 @@ standalone backend|relation|bulkwrite standalone backend|relation|init standalone backend|relation|normal standalone backend|relation|vacuum +standalone backend|temp relation|normal standalone backend|wal|init standalone backend|wal|normal startup|relation|bulkread @@ -104,7 +105,7 @@ walsummarizer|wal|init walsummarizer|wal|normal walwriter|wal|init walwriter|wal|normal -(88 rows) +(89 rows) \a -- List of registered statistics kinds. SELECT id, name, fixed_amount, -- 2.56.1

view thread (6+ messages)  latest in thread

Message-ID: <179489222449.37099.6261619082241419378@gmail.com>
Permalink:  ../179489222449.37099.6261619082241419378@gmail.com/
Also on:    postgresql.org/message-id/179489222449.37099.6261619082241419378@gmail.com

 ·  · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: manuelreyesbravo@gmail.com, masao.fujii@gmail.com, michael@paquier.xyz, melanieplageman@gmail.com
  Subject: Re: Assertion failure with temporary relations in single-user mode
  In-Reply-To: <179489222449.37099.6261619082241419378@gmail.com>
  References: <CAHGQGwE0nhCjM53yWZjz8_uYPjSjxbYohvTxkZiWD2U8r6p-Tg@mail.gmail.com> <179489222449.37099.6261619082241419378@gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox