pg.ddx.io pgsql-hackers@postgresql.org mailing list archive help / color / mirror / Atom feed From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Andres Freund <andres@anarazel.de>
Cc: Alexander Korotkov <aekorotkov@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: David G. Johnston <david.g.johnston@gmail.com>
Cc: Corey Huinker <corey.huinker@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Joe Conway <mail@joeconway.com>
Cc: Nikita Glukhov <n.gluhov@postgrespro.ru>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Error-safe user functions
Date: Sun, 11 Dec 2022 12:24:11 -0500
Message-ID: <1805344.1670779451@sss.pgh.pa.us> (raw )
In-Reply-To: <2b1e7d56-6f37-bad9-9702-053ab55ecf60@dunslane.net >
References: <4009543.1670422833@sss.pgh.pa.us >
<6acddf68-7cb7-e9e7-a5a7-0abc87b3c55b@dunslane.net >
<CAKFQuwYdQqQru9tpMpY4JpCEJ8OeN8kwmBG6DY2QyzE+5znA6Q@mail.gmail.com >
<4111458.1670444176@sss.pgh.pa.us >
<3211.1670452341@sss.pgh.pa.us >
<20221207233518.sudtaxn6omtvpzvr@awork3.anarazel.de >
<186288.1670517119@sss.pgh.pa.us >
<CA+TgmoZOhQ8FfWH9_r58tLtb=AwBn=7ugO2PHh6moR8jhYviUA@mail.gmail.com >
<20221208215836.3naznqmal2m32hzc@awork3.anarazel.de >
<512551.1670540229@sss.pgh.pa.us >
<20221209023351.l362yejerfoq3lfp@awork3.anarazel.de >
<633426.1670554790@sss.pgh.pa.us >
<01ff2051-806d-af2f-4f9e-793f7ba9a3f8@dunslane.net >
<778369.1670598993@sss.pgh.pa.us >
<5aaf7c66-9df9-21a9-1ff4-02c7848def52@dunslane.net >
<3bac9841-fe07-713d-fa42-606c225567d6@dunslane.net >
<1436686.1670701118@sss.pgh.pa.us >
<2b1e7d56-6f37-bad9-9702-053ab55ecf60@dunslane.net >
Andrew Dunstan <andrew@dunslane.net> writes:
> On 2022-12-10 Sa 14:38, Tom Lane wrote:
>> I have not done anything here about errors within JsonbValueToJsonb.
>> There would need to be another round of API-extension in that area
>> if we want to be able to trap its errors. As you say, those are mostly
>> about exceeding implementation size limits, so I suppose one could argue
>> that they are not so different from palloc failure. It's still annoying.
>> If people are good with the changes attached, I might take a look at
>> that.
> Awesome.
I spent some time looking at this, and was discouraged to conclude
that the notational mess would probably be substantially out of
proportion to the value. The main problem is that we'd have to change
the API of pushJsonbValue, which has more than 150 call sites, most
of which would need to grow a new test for failure return. Maybe
somebody will feel like tackling that at some point, but not me today.
regards, tom lane
view thread (175+ messages) latest in thread
Message-ID: <1805344.1670779451@sss.pgh.pa.us>
Permalink: ../1805344.1670779451@sss.pgh.pa.us/
Also on: postgresql.org/message-id/1805344.1670779451@sss.pgh.pa.us
copy link · copy postgr.es
reply Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andrew@dunslane.net, andres@anarazel.de, aekorotkov@gmail.com, robertmhaas@gmail.com, david.g.johnston@gmail.com, corey.huinker@gmail.com, alvherre@alvh.no-ip.org, mail@joeconway.com, n.gluhov@postgrespro.ru, pgsql-hackers@lists.postgresql.org
Subject: Re: Error-safe user functions
In-Reply-To: <1805344.1670779451@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox