pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Jaime Casanova <jcasanov@systemguards.com.ec>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: SQL-standard function body
Date: Thu, 08 Apr 2021 02:58:02 -0400
Message-ID: <1825656.1617865082@sss.pgh.pa.us> (raw)
In-Reply-To: <20210408064036.fwf2o6stviilbocf@nol>
References: <9277ef6a-bfa8-9c06-8e91-16c2892120cc@2ndquadrant.com>
	<20210403033943.dp6um65shvrovoj5@nol>
	<01c65ea6-e5bf-22f4-cacc-6d0f6853a965@2ndquadrant.com>
	<1646498.1617826937@sss.pgh.pa.us>
	<YG54YggzyPrTFE+e@paquier.xyz>
	<1819824.1617858962@sss.pgh.pa.us>
	<20210408052759.7bmyawm4djnrux6y@alap3.anarazel.de>
	<20210408054626.gyz3al2j5r5kzhrt@nol>
	<1821917.1617861925@sss.pgh.pa.us>
	<20210408063320.eciql3ay52ge5flz@alap3.anarazel.de>
	<20210408064036.fwf2o6stviilbocf@nol>

Julien Rouhaud <rjuju123@gmail.com> writes:
> On Wed, Apr 07, 2021 at 11:33:20PM -0700, Andres Freund wrote:
>> Nothing special, really. Surprised the BF doesn't see it:

> Is think this is because the buildfarm client is running installcheck for the
> contribs rather than check, and pg_stat_statements/Makefile has:
> # Disabled because these tests require "shared_preload_libraries=pg_stat_statements",
> # which typical installcheck users do not have (e.g. buildfarm clients).
> NO_INSTALLCHECK = 1

No, because if that were the explanation then we'd be getting no
buildfarm coverage at all for for pg_stat_statements.  Which aside
from being awful contradicts the results at coverage.postgresql.org.

I think Andres has the right idea that there's some more-subtle
variation in the test conditions, but (yawn) too tired to look
into it right now.

			regards, tom lane





view thread (90+ messages)  latest in thread

Message-ID: <1825656.1617865082@sss.pgh.pa.us>
Permalink:  ../1825656.1617865082@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1825656.1617865082@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, rjuju123@gmail.com, andres@anarazel.de, michael@paquier.xyz, peter.eisentraut@2ndquadrant.com, jcasanov@systemguards.com.ec
  Subject: Re: SQL-standard function body
  In-Reply-To: <1825656.1617865082@sss.pgh.pa.us>
  References: <9277ef6a-bfa8-9c06-8e91-16c2892120cc@2ndquadrant.com> <20210403033943.dp6um65shvrovoj5@nol> <01c65ea6-e5bf-22f4-cacc-6d0f6853a965@2ndquadrant.com> <1646498.1617826937@sss.pgh.pa.us> <YG54YggzyPrTFE+e@paquier.xyz> <1819824.1617858962@sss.pgh.pa.us> <20210408052759.7bmyawm4djnrux6y@alap3.anarazel.de> <20210408054626.gyz3al2j5r5kzhrt@nol> <1821917.1617861925@sss.pgh.pa.us> <20210408063320.eciql3ay52ge5flz@alap3.anarazel.de> <20210408064036.fwf2o6stviilbocf@nol> <1825656.1617865082@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox