pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Cleaning up historical portability baggage
Date: Sat, 06 Aug 2022 22:58:12 -0400
Message-ID: <182602.1659841092@sss.pgh.pa.us> (raw)
In-Reply-To: <20220807024623.v62stodeyondbpvc@awork3.anarazel.de>
References: <1249825.1658622186@sss.pgh.pa.us>
	<CA+hUKGLryBW4fNYoXzMG9y1e0H-QOTdSiTG46xCr1DNuuPwbeg@mail.gmail.com>
	<CA+hUKGJMcwbzRyfTocfxbPBUhERqKE42d-L22jQ+vpB7an-NjQ@mail.gmail.com>
	<20220804013546.h65najrzig764jar@awork3.anarazel.de>
	<3295936.1659577924@sss.pgh.pa.us>
	<20220804023010.24snkyq3hser5pxq@awork3.anarazel.de>
	<CA+hUKGLjffiULiVs5K4mi8FO5dgfngjKx5n9vZdDzQB9hzfurw@mail.gmail.com>
	<CA+hUKGJJxtpG12XFu6XJRxo+1ZmTrnYwY9_e8FgrVS7K9ar5Mg@mail.gmail.com>
	<20220805210823.u546w4p4wzfany7p@awork3.anarazel.de>
	<CA+hUKGLyGrqbC_YgW_+Fa1mLKev-WGmta1cDC5nVp+iuQ3bE0A@mail.gmail.com>
	<20220807024623.v62stodeyondbpvc@awork3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> On 2022-08-07 11:47:31 +1200, Thomas Munro wrote:
>> So what about strtof?  That's gotta be dead code too.  I gather we
>> still need commit 72880ac1's HAVE_BUGGY_STRTOF.

> Well, right now we don't refuse to build against the "wrong" runtimes, so it's
> hard to say whether you're looking at the right runtime. I don't think we need
> this if we're (as we should imo) only using the ucrt - that's microsoft's,
> which IIUC is ok?

You could pull it out and see if the buildfarm breaks, but my money
is on it breaking.  That HAVE_BUGGY_STRTOF stuff isn't very old.

			regards, tom lane





view thread (108+ messages)  latest in thread

Message-ID: <182602.1659841092@sss.pgh.pa.us>
Permalink:  ../182602.1659841092@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/182602.1659841092@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, thomas.munro@gmail.com, andrew@dunslane.net, robertmhaas@gmail.com
  Subject: Re: Cleaning up historical portability baggage
  In-Reply-To: <182602.1659841092@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox