From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Proposed refactoring of planner header files
Date: Mon, 28 Jan 2019 16:51:11 -0500
Message-ID: <18424.1548712271@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+TgmoY3ttQ6xkmZqF5KybA0BD=dimL_vqnBNo3tE2xLgGtoGQ@mail.gmail.com>
References: <11460.1548706639@sss.pgh.pa.us>
<CA+TgmoY3ttQ6xkmZqF5KybA0BD=dimL_vqnBNo3tE2xLgGtoGQ@mail.gmail.com>
Robert Haas <robertmhaas@gmail.com> writes:
> On Mon, Jan 28, 2019 at 3:17 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I'm really unhappy that force_parallel_mode and
>> parallel_leader_participation are being treated as planner GUCs.
> The only use of parallel_leader_participation at plan time seems to be
> to twiddle the costing, and the use of it in the executor is to decide
> whether to have the leader participate. So if the values differ,
> you'll get a plan running a behavior for which plan selection was not
> optimized. I don't know whether it's useful to intentionally allow
> this so that you can see how the same plan behaves under the other
> setting, or whether it's just a wart we'd be better off without. It
> might be confusing, though, if you change the setting and it doesn't
> force a replan.
Well, that puts it at the ill-considered end of the spectrum instead
of the outright-broken end, but I still say it's a bad idea. Planner
GUCs ought to control the produced plan, not other behaviors.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Proposed refactoring of planner header files
In-Reply-To: <18424.1548712271@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox