From: Tom Lane <tgl@sss.pgh.pa.us>
To: Yura Sokolov <y.sokolov@postgrespro.ru>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Add PortalDrop in exec_execute_message
Date: Fri, 11 Jun 2021 09:38:25 -0400
Message-ID: <1875433.1623418705@sss.pgh.pa.us> (raw)
In-Reply-To: <fb7b58d91dcc23b592ace457dc0f8c3a@postgrespro.ru>
References: <202106072107.d4i55hdscxqj@alvherre.pgsql>
<fb7b58d91dcc23b592ace457dc0f8c3a@postgrespro.ru>
Yura Sokolov <y.sokolov@postgrespro.ru> writes:
> This makes me think, Close message were intended to be used
> but simply forgotten when libpq patch were made.
> Tom, could I be right?
You could argue all day about what the intentions were nearly twenty
years ago. But the facts on the ground are that we don't issue Close
in those places, and changing it now would be a de facto protocol
change for applications. So I'm a hard -1 on these proposals.
(Alvaro's proposed change isn't a protocol break, since pipeline
mode hasn't shipped yet. It's trying to make some brand new code
act more like old code, which seems like a fine idea.)
I think that the actual problem here has been resolved in
commit bb4aed46a. Perhaps we should reconsider my decision not to
back-patch that. Unlike a protocol change, that one could possibly
be sane to back-patch. I didn't think it was worth the trouble and
risk, but maybe there's a case for it.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, y.sokolov@postgrespro.ru, alvherre@alvh.no-ip.org, pgsql-hackers@lists.postgresql.org
Subject: Re: Add PortalDrop in exec_execute_message
In-Reply-To: <1875433.1623418705@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox