public inbox for [email protected]  
help / color / mirror / Atom feed
From: Peter Eisentraut <[email protected]>
To: Dean Rasheed <[email protected]>
Cc: Andrew Dunstan <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: Underscores in numeric literals
Date: Thu, 2 Feb 2023 23:39:59 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAEZATCVedWe+u8_1iBzmJ5DBLxkEmS3RyJo6XGbaR62yvhrbZA@mail.gmail.com>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<CAEZATCUJPJHMokBEm4cYmq0t8T5hXMiKz6Rkqj5+EWOWF-==3A@mail.gmail.com>
	<CAEZATCVw8pqVn48S5ek6ZtAqWzjrJ+2q0-w3J=pOBKULwSPb-g@mail.gmail.com>
	<[email protected]>
	<CAEZATCVedWe+u8_1iBzmJ5DBLxkEmS3RyJo6XGbaR62yvhrbZA@mail.gmail.com>

On 31.01.23 17:09, Dean Rasheed wrote:
> On Tue, 31 Jan 2023 at 15:28, Peter Eisentraut
> <[email protected]> wrote:
>>
>> Did you have any thoughts about what to do with the float types?  I
>> guess we could handle those in a separate patch?
>>
> 
> I was assuming that we'd do nothing for float types, because anything
> we did would necessarily impact their performance.

Yeah, as long as we are using strtof() and strtod() we should just leave 
it alone.  If we have break that open and hand-code something, we can 
reconsider it.

So I think you could go ahead with committing your patch and we can 
consider this topic done for now.







view thread (6+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Underscores in numeric literals
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox