From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: /proc/self/oom_adj is deprecated in newer Linux kernels
Date: Tue, 12 Jun 2012 13:05:18 -0400
Message-ID: <18875.1339520718@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+TgmobWTavFRGw+ANZuzOxWBzk2MBVpYNLrqnaNdEH_iH621Q@mail.gmail.com>
References: <29121.1316185073@sss.pgh.pa.us>
<18434.1339519058@sss.pgh.pa.us>
<CA+TgmobWTavFRGw+ANZuzOxWBzk2MBVpYNLrqnaNdEH_iH621Q@mail.gmail.com>
Robert Haas <robertmhaas@gmail.com> writes:
> On Tue, Jun 12, 2012 at 12:37 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I still think it's sufficient to do what I suggested initially:
>>> ... The simplest, least risky change that I can think of is to
>>> copy-and-paste the relevant #ifdef code block in fork_process.c.
> I think my position, and the position of the people who responded to
> the original thread, was that it seems like you're architecting a
> kludge when it wouldn't be that hard to architect a nicer solution.
I'd be the first to agree it's a kluge. But the end result of the
previous discussion was that it wasn't so obvious how to architect
a nicer solution. Nor is there all that much room for people to use a
nicer solution, given that we need help from not just fork_process.c
but the root-privileged startup script (or lately in Fedora it's a
systemd unit script doing the privilege-increasing end of this).
In the short run, if we don't have consensus on this, I'll probably
just carry a Fedora patch like so:
- int fd = open("/proc/self/oom_adj", O_WRONLY, 0);
+ int fd = open("/proc/self/oom_score_adj", O_WRONLY, 0);
But it seems a tad silly to be carrying such a patch for a block of
code that is only of interest to Linux packagers anyway, and nearly
all such packagers are facing this same issue either now or in the
very near future.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com
Subject: Re: /proc/self/oom_adj is deprecated in newer Linux kernels
In-Reply-To: <18875.1339520718@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox