pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: ENOSPC FailedAssertion("!(RefCountErrors == 0)"
Date: Tue, 17 Jul 2018 21:11:19 -0400
Message-ID: <18926.1531876279@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+TgmoYR3b1hbkaHvch88F0st7WLrPriU=UzmGA5v1nvKWoYbA@mail.gmail.com>
References: <20180627233939.GA10276@telsasoft.com>
	<20180628020432.GB11054@paquier.xyz>
	<7317.1531694923@sss.pgh.pa.us>
	<20180716131337.usestwjviwwocpyz@alap3.anarazel.de>
	<20436.1531751966@sss.pgh.pa.us>
	<4993.1531773411@sss.pgh.pa.us>
	<14892.1531872065@sss.pgh.pa.us>
	<CA+TgmoY_aunsjo+jOEDc-p53Qvh7xxocccMiy8sy60ppPiyfXQ@mail.gmail.com>
	<18006.1531875305@sss.pgh.pa.us>
	<CA+TgmoYR3b1hbkaHvch88F0st7WLrPriU=UzmGA5v1nvKWoYbA@mail.gmail.com>

Robert Haas <robertmhaas@gmail.com> writes:
> On Tue, Jul 17, 2018 at 8:55 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Uh, what?  There are only a few callers of those, and they'd all have
>> crashed already if they were somehow dealing with an invalid buffer.

> Sorry, I meant Assert(owner != NULL).

Oh, gotcha: so that if an external developer hits it, he can more
easily see that this is from an (effective) API change and not some
mysterious bug.  Makes sense, especially if we include a comment:

    /* We used to allow pinning buffers without a resowner, but no more */
    Assert(CurrentResourceOwner != NULL);

I think it's sufficient to do this in ResourceOwnerEnlargeBuffers,
though.  The other two should be unreachable without having gone
through that.

			regards, tom lane




view thread (15+ messages)  latest in thread

Message-ID: <18926.1531876279@sss.pgh.pa.us>
Permalink:  ../18926.1531876279@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/18926.1531876279@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com, andres@anarazel.de, michael@paquier.xyz, pryzby@telsasoft.com
  Subject: Re: ENOSPC FailedAssertion("!(RefCountErrors == 0)"
  In-Reply-To: <18926.1531876279@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox