From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: GCC 7 warnings
Date: Thu, 04 May 2017 00:21:38 -0400
Message-ID: <19105.1493871698@sss.pgh.pa.us> (raw)
In-Reply-To: <b79425b4-288b-19f7-2fb6-b65fc2a772bc@2ndquadrant.com>
References: <dd7e5c64-86ec-9e96-e682-a57d1cb9bcc2@2ndquadrant.com>
<b79425b4-288b-19f7-2fb6-b65fc2a772bc@2ndquadrant.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 4/10/17 11:03, Peter Eisentraut wrote:
>> The release of GCC 7 is approaching [0], and the number of warnings in
>> PostgreSQL has gone up since we last looked [1]. Output attached. (My
>> version is 7.0.1 20170408.)
> GCC 7 has been released.
> Should we backpatch these warning fixes? The commit in question is
> 6275f5d28a1577563f53f2171689d4f890a46881. (I haven't actually checked
> whether backpatches well.)
Seems like that patch represents generally better coding practice,
and applying it would reduce cross-branch differences that would be
hazards for future patches, so I'm mostly +1 for this.
But I'd suggest waiting till after next week's releases. If there
are any problems induced by this, we'd be more likely to find them
with another three months' time before it hits the wild.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, peter.eisentraut@2ndquadrant.com
Subject: Re: GCC 7 warnings
In-Reply-To: <19105.1493871698@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox