agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feedFrom: Antonin Houska <ah@cybertec.at>
To: Tomas Vondra <tomas@vondra.me>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: vignesh C <vignesh21@gmail.com>
Cc: Srinath Reddy Sadipiralla <srinath2133@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Cc: Mihail Nikalayeu <mihailnikalayeu@gmail.com>
Cc: Matthias van de Meent <boekewurm+postgres@gmail.com>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Robert Treat <rob@xzilla.net>
Subject: Re: Adding REPACK [concurrently]
Date: Wed, 08 Apr 2026 12:46:46 +0200
Message-ID: <19118.1775645206@localhost> (raw)
In-Reply-To: <1c197f2d-49a2-4830-8dde-55867218b62d@vondra.me>
References: <202604060918.qw5ms7cbr2hz@alvherre.pgsql>
<1c197f2d-49a2-4830-8dde-55867218b62d@vondra.me>
Tomas Vondra <tomas@vondra.me> wrote:
> while building on a rpi5 with a 32-bit system, I'm getting these warnings:
>
> config.status: linking src/makefiles/Makefile.linux to src/Makefile.port
> In file included from ../../../src/include/access/tupmacs.h:20,
> from ../../../src/include/access/htup_details.h:20,
> from ../../../src/include/access/relscan.h:17,
> from ../../../src/include/access/heapam.h:19,
> from repack.c:36:
> In function ‘VARSIZE_ANY’,
> inlined from ‘restore_tuple’ at repack.c:2731:15:
> ../../../src/include/varatt.h:243:51: warning: array subscript
> ‘varattrib_4b[0]’ is partly outside array bounds of ‘union
> <anonymous>[1]’ [-Warray-bounds=]
> 243 | ((((const varattrib_4b *) (PTR))->va_4byte.va_header >>
> 2) & 0x3FFFFFFF)
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
> ../../../src/include/varatt.h:467:24: note: in expansion of macro
> ‘VARSIZE_4B’
> 467 | return VARSIZE_4B(PTR);
> | ^~~~~~~~~~
> repack.c: In function ‘restore_tuple’:
> repack.c:2717:49: note: object ‘chunk_header’ of size 4
> 2717 | } chunk_header;
> | ^~~~~~~~~~~~
> In function ‘VARSIZE_ANY’,
> inlined from ‘restore_tuple’ at repack.c:2734:4:
> ../../../src/include/varatt.h:243:51: warning: array subscript
> ‘varattrib_4b[0]’ is partly outside array bounds of ‘union
> <anonymous>[1]’ [-Warray-bounds=]
> 243 | ((((const varattrib_4b *) (PTR))->va_4byte.va_header >>
> 2) & 0x3FFFFFFF)
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
> ../../../src/include/varatt.h:467:24: note: in expansion of macro
> ‘VARSIZE_4B’
> 467 | return VARSIZE_4B(PTR);
> | ^~~~~~~~~~
> repack.c: In function ‘restore_tuple’:
> repack.c:2717:49: note: object ‘chunk_header’ of size 4
> 2717 | } chunk_header;
> | ^~~~~~~~~~~~
> I'm not sure if it's just the compiler (gcc 14.2) being pesky, or if
> it's an actual issue. The repack tests seem to pass fine.
We already introduced this definition above in the function to suppress this
kind of warning
union
{
alignas(int32) varlena hdr;
char data[sizeof(void *)];
} chunk_header;
The problem on a 32-bit system probably is that sizeof(void *) is 4. We need
some other constant. Maybe (sizeof(varlena) + 1) ...
Thanks.
--
Antonin Houska
Web: https://www.cybertec-postgresql.com
view thread (416+ messages) latest in thread
Message-ID: <19118.1775645206@localhost>
Permalink: ../19118.1775645206@localhost/
Also on: postgresql.org/message-id/19118.1775645206@localhost
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: ah@cybertec.at, tomas@vondra.me, alvherre@alvh.no-ip.org, vignesh21@gmail.com, srinath2133@gmail.com, amit.kapila16@gmail.com, mihailnikalayeu@gmail.com, boekewurm+postgres@gmail.com, pgsql-hackers@lists.postgresql.org, rob@xzilla.net
Subject: Re: Adding REPACK [concurrently]
In-Reply-To: <19118.1775645206@localhost>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox