pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Langote <amitlangote09@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org, Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Subject: Re: ATTACH PARTITION seems to ignore column generation status
Date: Mon, 09 Jan 2023 21:38:03 -0500
Message-ID: <191819.1673318283@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+HiwqG0rdcU1d06KPGaeV3WLETa8oadLNK8WKmKD2KWMzRPaw@mail.gmail.com>
References: <2793383.1672944799@sss.pgh.pa.us>
	<CA+HiwqEDfKy6znR_AHvH8CYgjxSo19rX3DH-3e0rgb0qsuGW_w@mail.gmail.com>
	<3016779.1673026372@sss.pgh.pa.us>
	<44978.1673300465@sss.pgh.pa.us>
	<CA+HiwqG0rdcU1d06KPGaeV3WLETa8oadLNK8WKmKD2KWMzRPaw@mail.gmail.com>

Amit Langote <amitlangote09@gmail.com> writes:
> Thanks for the patch.  It looks good, though I guess you said that we
> should also change the error message that CREATE TABLE ... PARTITION
> OF emits to match the other cases while we're here.  I've attached a
> delta patch.

Thanks.  I hadn't touched that issue because I wasn't entirely sure
which error message(s) you were unhappy with.  These changes look
fine offhand.

			regards, tom lane





view thread (14+ messages)  latest in thread

Message-ID: <191819.1673318283@sss.pgh.pa.us>
Permalink:  ../191819.1673318283@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/191819.1673318283@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, amitlangote09@gmail.com, peter.eisentraut@enterprisedb.com
  Subject: Re: ATTACH PARTITION seems to ignore column generation status
  In-Reply-To: <191819.1673318283@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox