agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feedFrom: Antonin Houska <ah@cybertec.at>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Mihail Nikalayeu <mihailnikalayeu@gmail.com>
Cc: Srinath Reddy Sadipiralla <srinath2133@gmail.com>
Cc: Matthias van de Meent <boekewurm+postgres@gmail.com>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Robert Treat <rob@xzilla.net>
Subject: Re: Adding REPACK [concurrently]
Date: Wed, 01 Apr 2026 14:31:21 +0200
Message-ID: <193349.1775046681@localhost> (raw)
In-Reply-To: <CAA4eK1+CNiuphtE=wwExsHD_McmYtGp2XK4qwX146VqRbgXmbA@mail.gmail.com>
References: <90700.1774627975@localhost>
<202603271635.owyhm7btgoic@alvherre.pgsql>
<CAA4eK1++8RmH9PaFMQCahZQ-PfE5DN0vrCsa4_rSQ6G877Lj3w@mail.gmail.com>
<228982.1774967782@localhost>
<CAA4eK1L58pxsOPoFD7+4CaNXTfkKJz7x_ZiS4nskMUq8FsEsGA@mail.gmail.com>
<49194.1775036606@localhost>
<CAA4eK1+CNiuphtE=wwExsHD_McmYtGp2XK4qwX146VqRbgXmbA@mail.gmail.com>
Amit Kapila <amit.kapila16@gmail.com> wrote:
> On Wed, Apr 1, 2026 at 3:13 PM Antonin Houska <ah@cybertec.at> wrote:
> >
> > Nevertheless, I'm not sure it's a good idea for snapbuild.c to handle special
> > cases like REPACK. Instead, I'm thinking if snapbuild.c can safely ignore XIDs
> > of backends connected to databases other than the one we're decoding.
> >
>
> What if such transactions have made changes in the global catalog?
> Even if that won't matter, I feel such a change would be quite
> fundamental to snapbuild machinery and changing at this point would be
> risky.
I had thought that catalog is usually needed only to retrieve the tuple
descriptor, but regression tests with some Assert() statements prove now that
shared catalogs can be accessed too. So that idea does not seem to be useful.
--
Antonin Houska
Web: https://www.cybertec-postgresql.com
view thread (416+ messages) latest in thread
Message-ID: <193349.1775046681@localhost>
Permalink: ../193349.1775046681@localhost/
Also on: postgresql.org/message-id/193349.1775046681@localhost
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: ah@cybertec.at, amit.kapila16@gmail.com, alvherre@alvh.no-ip.org, mihailnikalayeu@gmail.com, srinath2133@gmail.com, boekewurm+postgres@gmail.com, pgsql-hackers@lists.postgresql.org, rob@xzilla.net
Subject: Re: Adding REPACK [concurrently]
In-Reply-To: <193349.1775046681@localhost>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox