pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Vitaly Burovoy <vitaly.burovoy@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: identity columns
Date: Tue, 04 Apr 2017 13:28:44 -0400
Message-ID: <19455.1491326924@sss.pgh.pa.us> (raw)
In-Reply-To: <38c3769c-eec5-19c6-ce33-16838de77ccc@2ndquadrant.com>
References: <CAKOSWNmKbthEdV0m1J=V7r6nDyPk8diKwHW93jYbB+wnXd-c1A@mail.gmail.com>
	<ed41b243-63b2-f287-e7b0-8b2ac7266d66@2ndquadrant.com>
	<CAKOSWNnMp0sKZzcX0zSKJOTSb1Fas02+xTW=kvGMu2NhRiOAbg@mail.gmail.com>
	<ec772da8-3443-b39d-e25e-138ef01a71c1@2ndquadrant.com>
	<CAKOSWNnXmM6YBXNzGnXtZQMPjDgJF+a3Wx53Wzmrq5wqDyRX7Q@mail.gmail.com>
	<c05eefac-0b55-74df-6343-71d232c15bc5@2ndquadrant.com>
	<CAKOSWNmRm0ydv1Yp8OzZ_GPh6Kfyhk+o-fxRb6onGfp433afFA@mail.gmail.com>
	<06a416db-e35b-36d1-7e2f-0affdee24745@2ndquadrant.com>
	<CAKOSWN=U0wfqjPuUbSEMAn_dcP7QnD_U0KskYf7OVhkVqs8CXA@mail.gmail.com>
	<4b1d703f-818f-00bf-4169-3279af377f3d@2ndquadrant.com>
	<20170403181918.55rci53cll6fhcq6@alap3.anarazel.de>
	<38c3769c-eec5-19c6-ce33-16838de77ccc@2ndquadrant.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 4/3/17 14:19, Andres Freund wrote:
> +			*op->resvalue = Int64GetDatum(nextval_internal(op->d.nextvalueexpr.seqid, false));

>> Is it guaranteed that the caller expects an int64?  I saw that
>> nextvalueexpr's have a typeid field.

> It expects one of the integer types.  We could cast the result of
> Int64GetDatum() to the appropriate type, but that wouldn't actually do
> anything.

Uh, really?  On 32-bit platforms, int64 and int32 datums have entirely
different representations.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (55+ messages)  latest in thread

Message-ID: <19455.1491326924@sss.pgh.pa.us>
Permalink:  ../19455.1491326924@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/19455.1491326924@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, peter.eisentraut@2ndquadrant.com, andres@anarazel.de, vitaly.burovoy@gmail.com
  Subject: Re: identity columns
  In-Reply-To: <19455.1491326924@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox