pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: Alexander Korotkov <a.korotkov@postgrespro.ru>
Cc: Nikita Glukhov <n.gluhov@postgrespro.ru>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Oleg Bartunov <obartunov@gmail.com>
Cc: Pavel Stehule <pavel.stehule@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: jsonpath
Date: Tue, 20 Mar 2018 01:36:18 -0400
Message-ID: <19506.1521524178@sss.pgh.pa.us> (raw)
In-Reply-To: <CAA8=A796mY7kJdKARt7B+faW70-c8mRh+Ff_joBJ+NyCFLv3Gg@mail.gmail.com>
References: <fcc6fc6a-b497-f39a-923d-aa34d0c588e8@2ndQuadrant.com>
	<CAFj8pRAhPnD=sPu-E=rwfcbgeZ8PLczYEzCsvgNYLtybSy9-=g@mail.gmail.com>
	<9f845926-0d7d-7c4d-75e3-b1e921a1677a@2ndQuadrant.com>
	<CAFj8pRBCvhgLCROfSCPGmwWZpSY+dKQN4O9xRe+1-wjBiXiHkA@mail.gmail.com>
	<bad98003-31ba-523e-d76c-3679efb2e732@2ndQuadrant.com>
	<CAFj8pRDWSCWd1JxA8srwbfL5cPgz2b5minq2UsM=cxgsFF-orw@mail.gmail.com>
	<48f13b75-0be7-c356-ff26-1db743add56e@postgrespro.ru>
	<7b4b8973-43f5-71c5-bf86-51cb5798dd88@2ndQuadrant.com>
	<f0b44fe7-d47a-eff2-592c-d9dbe4a63f75@2ndQuadrant.com>
	<5290ddd1-f23e-a53a-cae0-830dbde0a5fe@2ndQuadrant.com>
	<604ffe9c-b42e-7c42-e16b-aa44c3a12c3c@postgrespro.ru>
	<927f72f0-6832-a4ca-5676-b0ab5a2895d4@postgrespro.ru>
	<CAF4Au4wxHuEeZrMxxKXUYcs1kDws-f0oW0-sEyun388-U-NOxw@mail.gmail.com>
	<9a1ac993-7608-797c-2095-c735605da82f@postgrespro.ru>
	<CA+TgmoYXtoPPaV-OEUfqujCcfKp+ZT=KOuPHkhRoQL_iYzQ8yQ@mail.gmail.com>
	<94ace92c-714c-903c-fab2-31fb838204ad@postgrespro.ru>
	<CAPpHfduYzfOrtS0i2XuKpBRJY5Zhhd! V7yw89U3HaXEjymfBhTQ@mail.gmail.com>
	<CAA8=A796mY7kJdKARt7B+faW70-c8mRh+Ff_joBJ+NyCFLv3Gg@mail.gmail.com>

Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
>> That seems like a quite limited list of functions.  What about
>> reworking them providing a way of calling them without risk of
>> exception?

> I haven't seen a response to this email. Do we need one before
> proceeding any further with jsonpath?

I've not been following this thread in detail, but IMO any code anywhere
that thinks that no error can be thrown out of non-straight-line code is
broken beyond redemption.  What, for example, happens if we get ENOMEM
within one of the elog.c functions?

I did look through 0007-jsonpath-arithmetic-error-handling-v12.patch,
and I can't believe that's seriously proposed for commit.  It's making
some pretty fragile changes in error handling, and so far as I can
find there is not even one line of commentary as to what the new
design rules are supposed to be.  Even if it's completely bug-free
today (which I would bet against), how could we keep it so?

			regards, tom lane




view thread (198+ messages)  latest in thread

Message-ID: <19506.1521524178@sss.pgh.pa.us>
Permalink:  ../19506.1521524178@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/19506.1521524178@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andrew.dunstan@2ndquadrant.com, a.korotkov@postgrespro.ru, n.gluhov@postgrespro.ru, robertmhaas@gmail.com, obartunov@gmail.com, pavel.stehule@gmail.com
  Subject: Re: jsonpath
  In-Reply-To: <19506.1521524178@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox