From: Tom Lane <tgl@sss.pgh.pa.us>
To: ITAGAKI Takahiro <itagaki.takahiro@oss.ntt.co.jp>
Cc: pgsql-hackers@postgresql.org, Katsuhiko Okano <okano.katsuhiko@oss.ntt.co.jp>
Subject: Re: CSStorm occurred again by postgreSQL8.2
Date: Mon, 07 Aug 2006 09:09:37 -0400
Message-ID: <19738.1154956177@sss.pgh.pa.us> (raw)
In-Reply-To: <20060807114525.5266.ITAGAKI.TAKAHIRO@oss.ntt.co.jp>
References: <200607181650.EDC81237.LOBJUTPuIPPBLLV@oss.ntt.co.jp>
<5126.1153241513@sss.pgh.pa.us>
<20060807114525.5266.ITAGAKI.TAKAHIRO@oss.ntt.co.jp>
ITAGAKI Takahiro <itagaki.takahiro@oss.ntt.co.jp> writes:
> The invokers of SubTrans module are two SubTransGetTopmostTransaction()
> in HeapTupleSatisfiesSnapshot(). When I disabled the calls, CSStorm did
> not occur. SubTransGetTopmostTransaction returns the argument without
> change when we don't use SAVEPOINTs.
> If we optimize for non-subtransactions, we can avoid to lock SubTrans
> for check visiblities of tuples inserted by top transactions.
Only for top transactions still in progress, so I doubt that would
help much.
I'm wondering about doing something similar to what
TransactionIdIsInProgress does, ie, make use of the PGPROC lists
of live subtransactions. Suppose that GetSnapshotData copies not
only top xids but live subxids into the snapshot, and adds a flag
indicating whether the subxids are complete (ie, none of the subxid
lists have overflowed). Then if the flag is set, tqual.c doesn't
need to do SubTransGetTopmostTransaction() before searching the
list.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, itagaki.takahiro@oss.ntt.co.jp, okano.katsuhiko@oss.ntt.co.jp
Subject: Re: CSStorm occurred again by postgreSQL8.2
In-Reply-To: <19738.1154956177@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox