pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Dean Rasheed <dean.a.rasheed@gmail.com>
Cc: David Rowley <david.rowley@2ndquadrant.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: Mark Dilger <hornschnorter@gmail.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [HACKERS] PATCH: multivariate histograms and MCV lists
Date: Wed, 13 Mar 2019 02:25:40 +0100
Message-ID: <19f76496-dcf3-ccea-dd82-26fbed57b8f5@2ndquadrant.com> (raw)
In-Reply-To: <CAEZATCU_6zLnictjY2jmy-7Wwh=HSe9YN+mn41L=Ea=t5ivMWw@mail.gmail.com>
References: <b114496c-ee55-11f0-b17a-b00ec22677bc@2ndquadrant.com>
	<20190206012140.GA3626@alvherre.pgsql>
	<CAKJS1f_gA+odYxRD45LHrKhFKF00CGBKWELQxAGF=L6=6NqWVw@mail.gmail.com>
	<53386926-08a6-76f7-6a8f-f36e4ffb1b9d@2ndquadrant.com>
	<60a3741a-dcd5-4a30-90a2-c427b94524fc@2ndquadrant.com>
	<CAEZATCWAT3hEvWv2JoMfioroy41eKb7roCaM3D0b-BDAoKTbFw@mail.gmail.com>
	<CAEZATCVG+xCQc8NGx_LCY8xr-RcwaxQLfibkMnTT5A60DVturg@mail.gmail.com>
	<5c865c03-9963-c62a-ef0c-c42f3c0e855f@2ndquadrant.com>
	<CAEZATCU_6zLnictjY2jmy-7Wwh=HSe9YN+mn41L=Ea=t5ivMWw@mail.gmail.com>

Hi,

attached is an updated version of the patch, addressing most of the
issues raised in the recent reviews. There are two main exceptions:

1) I haven't reworked the regression tests to use a function to check
cardinality estimates and making them faster.

2) Review handling of bitmap in statext_is_compatible_clause_internal
when processing AND/OR/NOT clauses.

I plan to look into those items next, but I don't want block review of
other parts of the patch unnecessarily.


regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachments:

  [application/gzip] 0001-multivariate-MCV-lists-20190312.patch.gz (39.8K, ../19f76496-dcf3-ccea-dd82-26fbed57b8f5@2ndquadrant.com/2-0001-multivariate-MCV-lists-20190312.patch.gz)
  download

  [application/gzip] 0002-multivariate-histograms-20190312.patch.gz (49.0K, ../19f76496-dcf3-ccea-dd82-26fbed57b8f5@2ndquadrant.com/3-0002-multivariate-histograms-20190312.patch.gz)
  download

view thread (167+ messages)  latest in thread

Message-ID: <19f76496-dcf3-ccea-dd82-26fbed57b8f5@2ndquadrant.com>
Permalink:  ../19f76496-dcf3-ccea-dd82-26fbed57b8f5@2ndquadrant.com/
Also on:    postgresql.org/message-id/19f76496-dcf3-ccea-dd82-26fbed57b8f5@2ndquadrant.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tomas.vondra@2ndquadrant.com, dean.a.rasheed@gmail.com, david.rowley@2ndquadrant.com, alvherre@2ndquadrant.com, michael@paquier.xyz, andres@anarazel.de, thomas.munro@enterprisedb.com, bruce@momjian.us, hornschnorter@gmail.com
  Subject: Re: [HACKERS] PATCH: multivariate histograms and MCV lists
  In-Reply-To: <19f76496-dcf3-ccea-dd82-26fbed57b8f5@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox