From: tushar <tushar.ahuja@enterprisedb.com>
To: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Mark Dilger <mark.dilger@enterprisedb.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: refactoring basebackup.c
Date: Mon, 19 Jul 2021 18:02:43 +0530
Message-ID: <1cee30a1-b7db-41fa-7ec7-4e2750e5132d@enterprisedb.com> (raw)
In-Reply-To: <CAFiTN-uhg4iKA7FGWxaG9J8WD_LTx655+AUW3_KiK1=SakQy4A@mail.gmail.com>
References: <CA+TgmoZGwR=ZVWFeecncubEyPdwghnvfkkdBe9BLccLSiqdf9Q@mail.gmail.com>
<CA+TgmoZBqs7KkyBUFzXQaztuonKanuOV+f_7DYsHOpJs=0B2DA@mail.gmail.com>
<CA+TgmoY5zpS=gJj2O0PXi6YGao5YR89v0qN_xZzWNvff2Tug+Q@mail.gmail.com>
<58D2BD01-B541-4032-9C0B-B6143841E7ED@enterprisedb.com>
<CA+TgmoYgVN=-Yoh71r3P9N7eKysd7_9b9s+1QFfFcs3w7Z-tig@mail.gmail.com>
<4799332e-61ae-3a08-c5da-38f61fa0493d@enterprisedb.com>
<CAFiTN-uhg4iKA7FGWxaG9J8WD_LTx655+AUW3_KiK1=SakQy4A@mail.gmail.com>
On 7/16/21 12:43 PM, Dilip Kumar wrote:
> I think the problem is that bbsink_gzip_end_archive() is not
> forwarding the end request to the next bbsink. The attached patch so
> fix it.
Thanks Dilip. Reported issue seems to be fixed now with your patch
[edb@centos7tushar bin]$ ./pg_basebackup --server-compression=gzip4 -t
server:/tmp/data_2 -v -Xnone -R
pg_basebackup: initiating base backup, waiting for checkpoint to complete
pg_basebackup: checkpoint completed
NOTICE: all required WAL segments have been archived
pg_basebackup: base backup completed
[edb@centos7tushar bin]$
OR
[edb@centos7tushar bin]$ ./pg_basebackup -t server:/tmp/pv1 -Xnone
--server-compression=gzip4 -r 1024 -P
NOTICE: all required WAL segments have been archived
23133/23133 kB (100%), 1/1 tablespace
[edb@centos7tushar bin]$
Please refer this scenario ,where -R option is working with '-t server'
but not with -Ft
--not working
[edb@centos7tushar bin]$ ./pg_basebackup --server-compression=gzip4
-Ft -D ccv -Xnone -R --no-manifest
pg_basebackup: error: unable to parse archive: base.tar.gz
pg_basebackup: only tar archives can be parsed
pg_basebackup: the -R option requires pg_basebackup to parse the archive
pg_basebackup: removing data directory "ccv"
--working
[edb@centos7tushar bin]$ ./pg_basebackup --server-compression=gzip4 -t
server:/tmp/ccv -Xnone -R --no-manifest
NOTICE: all required WAL segments have been archived
[edb@centos7tushar bin]$
--
regards,tushar
EnterpriseDB https://www.enterprisedb.com/
The Enterprise PostgreSQL Company
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tushar.ahuja@enterprisedb.com, dilipbalaut@gmail.com, robertmhaas@gmail.com, mark.dilger@enterprisedb.com
Subject: Re: refactoring basebackup.c
In-Reply-To: <1cee30a1-b7db-41fa-7ec7-4e2750e5132d@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox