From: Yury Zhuravlev <u.zhuravlev@postgrespro.ru>
To: pgsql-hackers@postgresql.org
Subject: Re: WIP: About CMake v2
Date: Fri, 19 Aug 2016 17:17:06 +0300
Message-ID: <1db85ec3-0cb0-4066-b156-baa110621eb2@postgrespro.ru> (raw)
In-Reply-To: <57B60F85.3020602@kaltenbrunner.cc>
References: <4184974.kkvGJ5GoEX@dinodell>
<1974943.sWDBYWy5U3@dinodell>
<56096E15.3040602@gmx.net>
<2319e612-6c78-4fd4-8ccb-e1fa1bc84c01@postgrespro.ru>
<57B60263.4020501@kaltenbrunner.cc>
<CAPfS4ZxpFsDYyBLnnVqXSdS=JWTDNxBaN0NaGRHZoNxy+=Voew@mail.gmail.com>
<57B60792.3000307@kaltenbrunner.cc>
<CAPfS4ZweZEzKdELrLQB0Ag61Qbn7RH2qm+nyPa_bodk6cJwG+w@mail.gmail.com>
<57B60F85.3020602@kaltenbrunner.cc>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Stefan Kaltenbrunner wrote:
> On 08/18/2016 09:30 PM, Christian Convey wrote:
>> Hi Karl,
>>
>> I'll need to let Yury answer your original question regarding the best
>> way to report CMake-related bugs.
>>
>> Regarding the errors you're getting... I just looked at CMake's
>> online documentation regarding your "target_compile_definitions" ...
>
> Well - "too old" is a relative term - cmake 2.8.10 was released in only
> october 2012 and cmake 2.8.11 in may 2013 so it is not even 4 years old,
> the oldest currently supported (though for not much longer) postgresql
> release 9.1 was released in september 2011 and 9.2 was also released
> before october 2012.
> So while Cmake compat might only make it for v10, I dont think that we
> can depend on bleeding edge version like that for our buildtools...
1. I don't know but nobody objections if we install latest CMake under
Windows or MacOSX but many if under Linux/*BSD. I have builded CMake
recently under old Solaris without any problems.
2. I use "graceful degradation" method and currently target is 3.0 version
BUT time to time I testing and backporting the code. I hope I can make all
features for 2.8.4 .
3. Please do not compare cmake and GNU Make. CMake it's like Autotools with
detect library scripts out the box. Every new version brings not only new
functions and syntax construction. Most fix in find_library scripts.
Besides you can't build project without gnu make, make, nmake, ninja and
etc because CMake generate files for another make systems. On this basis,
to CMake can not meet the same requirements for version as GNU Make. It is
quite another thing.
PS Special for Postgres in CMake 3.6 I implemented features for replace
gen_def.pl script under MSVC.
https://gitlab.kitware.com/cmake/cmake/merge_requests/29
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: u.zhuravlev@postgrespro.ru
Subject: Re: WIP: About CMake v2
In-Reply-To: <1db85ec3-0cb0-4066-b156-baa110621eb2@postgrespro.ru>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox