From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Kuntal Ghosh <kuntalghosh.2007@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: ALTER TABLE ... SET STORAGE does not propagate to indexes
Date: Wed, 6 May 2020 16:37:55 +0200
Message-ID: <1e19aeb2-c300-a8a0-e828-9090671eb428@2ndquadrant.com> (raw)
In-Reply-To: <8be09419-ed3d-93f9-9c29-2824b44a2c56@2ndquadrant.com>
References: <20200421235636.GA29434@alvherre.pgsql>
<8be09419-ed3d-93f9-9c29-2824b44a2c56@2ndquadrant.com>
On 2020-04-22 16:26, Peter Eisentraut wrote:
> On 2020-04-22 01:56, Alvaro Herrera wrote:
>> I'm surprised that this hasn't applied yet, because:
>>
>> On 2020-Apr-09, Peter Eisentraut wrote:
>>
>>> One thing to remember is that the current situation is broken. While you
>>> can set index columns to have different storage than the corresponding table
>>> columns, pg_dump does not preserve that, because it dumps indexes after
>>> ALTER TABLE commands. So at the moment, having these two things different
>>> isn't really supported.
>>
>> So I have to ask -- are you planning to get this patch pushed and
>> backpatched?
>
> I think I should, but I figured I want to give some extra time for
> people to consider the horror that I created in the test_decoding tests.
OK then, if there are no last-minute objects, I'll commit this for the
upcoming minor releases.
This is the patch summary again:
Date: Thu, 9 Apr 2020 14:10:01 +0200
Subject: [PATCH v3] Propagate ALTER TABLE ... SET STORAGE to indexes
When creating a new index, the attstorage setting of the table column
is copied to regular (non-expression) index columns. But a later
ALTER TABLE ... SET STORAGE is not propagated to indexes, thus
creating an inconsistent and undumpable state.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, alvherre@2ndquadrant.com, kuntalghosh.2007@gmail.com
Subject: Re: ALTER TABLE ... SET STORAGE does not propagate to indexes
In-Reply-To: <1e19aeb2-c300-a8a0-e828-9090671eb428@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox