From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Luke Lonergan <luke@brightforge.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Pg V10: Patch for bug in bonjour support
Date: Wed, 08 Nov 2017 17:02:59 -0500
Message-ID: <20002.1510178579@sss.pgh.pa.us> (raw)
In-Reply-To: <CAEepm=1wcqZJ1VUkCpAWiWUT8OcPsPVeabM_T4FQi+PFi9j9=g@mail.gmail.com>
References: <2D8331C5-D64F-44C1-8717-63EDC6EAF7EB@brightforge.com>
<CAEepm=1wcqZJ1VUkCpAWiWUT8OcPsPVeabM_T4FQi+PFi9j9=g@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Thomas Munro <thomas.munro@enterprisedb.com> writes:
> On Thu, Nov 9, 2017 at 10:05 AM, Luke Lonergan <luke@brightforge.com> wrote:
>> + AC_CHECK_LIB(dns_sd, DNSServiceRefSockFD, [], [AC_MSG_ERROR([library
>> 'dns_sd' is required for Bonjour])])
> It lives in libSystem.dylib (implicitly linked) on macOS, so that
> would break the build there. We'd need something a bit more
> conditional, but I don't know what.
A quick look at the Autoconf manual finds:
`AC_CHECK_LIB' requires some care in usage, and should be avoided
in some common cases. Many standard functions like `gethostbyname'
appear in the standard C library on some hosts, and in special
libraries like `nsl' on other hosts. On some hosts the special
libraries contain variant implementations that you may not want to
use. These days it is normally better to use
`AC_SEARCH_LIBS([gethostbyname], [nsl])' instead of
`AC_CHECK_LIB([nsl], [gethostbyname])'.
If Luke wants to check that that works for him, I can check it on
macOS.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, thomas.munro@enterprisedb.com, luke@brightforge.com
Subject: Re: Pg V10: Patch for bug in bonjour support
In-Reply-To: <20002.1510178579@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox