From: torikoshia <torikoshia@oss.nttdata.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: masao.fujii@oss.nttdata.com
Cc: bharath.rupireddyforpostgres@gmail.com
Cc: pgsql-hackers@postgresql.org
Subject: Re: Allow pg_archivecleanup to remove backup history files
Date: Wed, 19 Jul 2023 21:44:02 +0900
Message-ID: <2007681410e9316fd35f393769775430@oss.nttdata.com> (raw)
In-Reply-To: <ZLdsv5FK9cKvyUvj@paquier.xyz>
References: <b367dba446c2859358b15a5e18e4f165@oss.nttdata.com>
<20230621.115941.1395557545366586431.horikyota.ntt@gmail.com>
<a6fbcc52c0a5b4e53cd7227e3b1fc632@oss.nttdata.com>
<20230622.164710.2096056945333906873.horikyota.ntt@gmail.com>
<0fd031265a324696c2ac58c5d4b394ef@oss.nttdata.com>
<ZJ56y472dlI7gfhb@paquier.xyz>
<ZLdsv5FK9cKvyUvj@paquier.xyz>
On 2023-07-19 13:58, Michael Paquier wrote:
> On Fri, Jun 30, 2023 at 03:48:43PM +0900, Michael Paquier wrote:
>> I have begun cleaning up my board, and applied 0001 for the moment.
>
> And a few weeks later.. I have come around this thread and applied
> 0002 and 0003.
>
> The flow of 0002 was straight-forward. My main issue was in 0003,
> actually, where the TAP tests were kind of confusing as written:
> - There was no cleanup of the files still present after a single
> command check, which could easily mess up the tests.
> - The --dry-run case was using the list of WAL files for the extension
> pattern checks, hardcoding names based on the position of its array.
> I have switched that to use a third list of files, instead.
>
> The result looked OK and that can be extended easily for more
> patterns or more commands, so applied 0003 after doing these
> adjustments, coupled with a pgperltidy run, a pgperlcritic check and
> an indentation.
> --
> Michael
Thanks for the reviewing and applying the patches!
--
Regards,
--
Atsushi Torikoshi
NTT DATA CORPORATION
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: torikoshia@oss.nttdata.com, michael@paquier.xyz, horikyota.ntt@gmail.com, masao.fujii@oss.nttdata.com, bharath.rupireddyforpostgres@gmail.com
Subject: Re: Allow pg_archivecleanup to remove backup history files
In-Reply-To: <2007681410e9316fd35f393769775430@oss.nttdata.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox