From: Jeremy Kerr <jk@ozlabs.org>
To: pgsql-hackers@postgresql.org
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Subject: Re: [RFC,PATCH] SIGPIPE masking in local socket connections
Date: Tue, 2 Jun 2009 23:52:01 +1000
Message-ID: <200906022352.01814.jk@ozlabs.org> (raw)
In-Reply-To: <10549.1243949503@sss.pgh.pa.us>
References: <1243914753.517210.131510259224.0.gpush@pingu>
<10549.1243949503@sss.pgh.pa.us>
Tom,
> The consideration is that the application fails completely on server
> disconnect (because it gets SIGPIPE'd). This was long ago deemed
> unacceptable, and we aren't likely to change our opinion on that.
OK, understood. I'm guessing MSG_NOSIGNAL on the send() isn't portable
enough here?
> What disturbs me about your report is the suggestion that there are
> paths through that code that fail to protect against SIGPIPE. If so,
> we need to fix that.
I just missed the comment that pqsecure_read may end up writing to the
socket in the SSL case, so looks like all is fine here. We shouldn't see
a SIGPIPE from the recv() alone.
Cheers,
Jeremy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: jk@ozlabs.org, tgl@sss.pgh.pa.us
Subject: Re: [RFC,PATCH] SIGPIPE masking in local socket connections
In-Reply-To: <200906022352.01814.jk@ozlabs.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox