From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Boszormenyi Zoltan <zb@cybertec.at>
Cc: Peter Eisentraut <peter_e@gmx.net>
Cc: Noah Misch <noah@leadboat.com>
Cc: Michael Meskes <meskes@postgresql.org>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: PG Hackers <pgsql-hackers@postgresql.org>
Cc: Heikki Linnakangas <hlinnakangas@vmware.com>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: Hans-Jürgen Schönig <hs@cybertec.at>
Subject: Re: ECPG FETCH readahead
Date: Thu, 10 Oct 2013 19:16:49 -0300
Message-ID: <20131010221648.GK4825@eldon.alvh.no-ip.org> (raw)
In-Reply-To: <522EA559.4090105@cybertec.at>
References: <4F8CEB5A.100@cybertec.at>
<20120417044819.GA9043@feivel.credativ.lan>
<4F95613B.2030904@cybertec.at>
<20120424081714.GA12034@feivel.credativ.lan>
<520F4B90.2010800@cybertec.at>
<5226EA00.6040202@cybertec.at>
<1378517102.7389.2.camel@vanquo.pezone.net>
<522B7130.8040006@cybertec.at>
<1378775047.14736.0.camel@vanquo.pezone.net>
<522EA559.4090105@cybertec.at>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Boszormenyi Zoltan escribió:
> 2013-09-10 03:04 keltezéssel, Peter Eisentraut írta:
> >You need to update the dblink regression tests.
>
> Done.
Dude, this is an humongous patch. I was shocked by it initially, but on
further reading, I observed that it's only a huge patch which also does
some mechanical changes to test output. I think it'd be better to split
the part that's responsible for the changed lines in test output
mentioning "ecpg_process_output". That should be a reasonably small
patch which changes ecpg_execute slightly and adds the new function, is
followed by the enormous resulting mechanical changes in test output.
It should be possible to commit that relatively quickly. Then there's
the rest of the patch, which would adds a huge pile of new code.
I think there are some very minor changes to backend code as well --
would it make sense to post that as a separate piece?
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, zb@cybertec.at, peter_e@gmx.net, noah@leadboat.com, meskes@postgresql.org, robertmhaas@gmail.com, hlinnakangas@vmware.com, bruce@momjian.us, hs@cybertec.at
Subject: Re: ECPG FETCH readahead
In-Reply-To: <20131010221648.GK4825@eldon.alvh.no-ip.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox