From: Andres Freund <andres@2ndquadrant.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter_e@gmx.net>
Cc: Peter Geoghegan <pg@heroku.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Cc: Ants Aasma <ants@cybertec.at>
Subject: Re: better atomics - v0.2
Date: Tue, 24 Dec 2013 15:16:31 +0100
Message-ID: <20131224141631.GF26564@alap2.anarazel.de> (raw)
In-Reply-To: <CA+TgmoYJnc4B+8y01gRnAL52GTPbzc3ZsC4SdNW4LGxHqT3Bgg@mail.gmail.com>
References: <CA+TgmoYBW+ux5-8Ja=Mcyuy8=VXAnVRHp3Kess6Pn3DMXAPAEA@mail.gmail.com>
<20131115200416.GH5489@awork2.anarazel.de>
<CA+Tgmobhd5hwC+NzCfn2p1MO8EHZjhNgFQyLcA-cjRtSJzZJ6Q@mail.gmail.com>
<8392.1384873040@sss.pgh.pa.us>
<20131119151646.GD10498@alap2.anarazel.de>
<9336.1384875455@sss.pgh.pa.us>
<20131205113938.GC12398@alap2.anarazel.de>
<CA+TgmoYJnc4B+8y01gRnAL52GTPbzc3ZsC4SdNW4LGxHqT3Bgg@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
On 2013-12-23 15:04:08 -0500, Robert Haas wrote:
> On Thu, Dec 5, 2013 at 6:39 AM, Andres Freund <andres@2ndquadrant.com> wrote:
> > On 2013-11-19 10:37:35 -0500, Tom Lane wrote:
> >> Or does the warning
> >> mean code bloat (lots of useless copies of the inline function)?
> >
> > After thinking on that for a bit, yes that's a possible consequence, but
> > it's quite possible that it happens in cases where we don't get the
> > warning too, so I don't think that argument has too much bearing as I
> > don't recall a complaint about it.
>
> But I bet the warning we're getting there is complaining about exactly
> that thing. It's possible that it means "warning: i've optimized away
> your unused function into nothing" but I think it's more likely that
> it means "warning: i just emitted dead code". Indeed, I suspect that
> this is why that test is written that way in the first place.
I don't think that's particularly likely - remember, we're talking about
static inline functions here. So the compiler would have to detect that
there's an inline function which won't be used and then explicitly emit
a function body. That seems like an odd thing to do.
So, if there's compilers like that around, imo they have to deal with their
own problems. It's not like it will prohibit using postgres.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: andres@2ndquadrant.com, robertmhaas@gmail.com, tgl@sss.pgh.pa.us, peter_e@gmx.net, pg@heroku.com, ants@cybertec.at
Subject: Re: better atomics - v0.2
In-Reply-To: <20131224141631.GF26564@alap2.anarazel.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox