From: Stephen Frost <sfrost@snowman.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Shigeru Hanada <shigeru.hanada@gmail.com>
Cc: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: inherit support for foreign tables
Date: Fri, 31 Jan 2014 13:05:08 -0500
Message-ID: <20140131180508.GM2921@tamriel.snowman.net> (raw)
In-Reply-To: <14378.1391182237@sss.pgh.pa.us>
References: <52E5F3FD.6050000@lab.ntt.co.jp>
<52E6137B.1080704@lab.ntt.co.jp>
<CAEZqfEdojfdzt9pHwsdYURNL5+JNrDUF-iMtmyh-LdDeAWcncA@mail.gmail.com>
<CAEZqfEfYauyxZQvsKODM5BQKt+KsnNakFQxrHHdnivq6mO83rg@mail.gmail.com>
<32648.1391097891@sss.pgh.pa.us>
<CA+TgmoZwhrVF5t6d6anyd1UOh=B6MuPB+uruuXtVo0gHH9txPg@mail.gmail.com>
<20275.1391119500@sss.pgh.pa.us>
<CA+Tgmoa9yGWfq7Yybf6KYjXRJFarUh7pxCq6K_k86d-Xmf3QtA@mail.gmail.com>
<20140131152136.GJ2921@tamriel.snowman.net>
<14378.1391182237@sss.pgh.pa.us>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
* Tom Lane (tgl@sss.pgh.pa.us) wrote:
> Stephen Frost <sfrost@snowman.net> writes:
> > I agree that using the FDW-specific options is the right approach and
> > disallowing those to be set on foreign tables makes sense. I don't
> > particularly like the idea of applying changes during inheiritance
> > which we wouldn't allow the user to do directly. While it might be a
> > no-op and no FDW might use it, it'd still be confusing.
>
> If we don't allow it directly, why not? Seems rather arbitrary.
I'm apparently missing something here. From my perspective, they're
either allowed or they're not and if they aren't allowed then they
shouldn't be allowed to happen. I'd view this like a CHECK constraint-
if it's a foreign table then it can't have a value for SET STORAGE. I
don't see why it would be 'ok' to allow it to be set if we're setting it
as part of inheiritance but otherwise not allow it to be set.
Thanks,
Stephen
Attachments:
[application/pgp-signature] signature.asc (835B, ../20140131180508.GM2921@tamriel.snowman.net/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: sfrost@snowman.net, tgl@sss.pgh.pa.us, robertmhaas@gmail.com, shigeru.hanada@gmail.com, fujita.etsuro@lab.ntt.co.jp
Subject: Re: inherit support for foreign tables
In-Reply-To: <20140131180508.GM2921@tamriel.snowman.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox