pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Jaime Casanova <jaime@2ndquadrant.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: view reloptions
Date: Mon, 14 Jul 2014 17:40:26 -0400
Message-ID: <20140714214026.GD8170@eldon.alvh.no-ip.org> (raw)
In-Reply-To: <CAJKUy5iqMHAtM4Lii6SELBpYdnfS2np55SUxZF0LVkoCjNz1_g@mail.gmail.com>
References: <20140611194633.GH18688@eldon.alvh.no-ip.org>
	<CAJKUy5iqMHAtM4Lii6SELBpYdnfS2np55SUxZF0LVkoCjNz1_g@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Jaime Casanova wrote:

> Attached is a patch moving the reloptions of views into its own structure.
> i also created a view_reloptions() function in order to not use
> heap_reloptions() for views, but maybe that was too much?

No, that was part of what I was thinking too -- I have pushed this now.
Many thanks.

> i haven't seen the check_option_offset thingy yet, but i hope to take
> a look at that tomorrow.

I'm guessing you didn't get around to doing this.  I gave it a quick
look and my conclusion is that it requires somewhat more work than it's
worth.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (5+ messages)

Message-ID: <20140714214026.GD8170@eldon.alvh.no-ip.org>
Permalink:  ../20140714214026.GD8170@eldon.alvh.no-ip.org/
Also on:    postgresql.org/message-id/20140714214026.GD8170@eldon.alvh.no-ip.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: alvherre@2ndquadrant.com, jaime@2ndquadrant.com
  Subject: Re: view reloptions
  In-Reply-To: <20140714214026.GD8170@eldon.alvh.no-ip.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox