pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Emre Hasegeli <emre@hasegeli.com>
To: Alexander Korotkov <aekorotkov@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Cc: Heikki Linnakangas <hlinnakangas@vmware.com>
Subject: Re: KNN-GiST with recheck
Date: Wed, 17 Sep 2014 11:12:50 +0300
Message-ID: <20140917081250.GA28651@hasegeli.com> (raw)
In-Reply-To: <CAPpHfdvEpZAJrMBkNrCguG4fCK5QtZjARPti7LnL5chsSuD=Sg@mail.gmail.com>
References: <CAPpHfdvn5jxgh-rVMz7c2vXoYW_W7dGrJjQkVAtaCr=-ZMCADA@mail.gmail.com>
	<20140803134809.GA58181@hasegeli-2.local>
	<CAPpHfdu3JmBrsgsrtaAQJMpXyMgrW+T2P7Gmf9oP8L1V7zLvOg@mail.gmail.com>
	<20140914180936.GA5084@hasegeli.com>
	<CAPpHfdvEpZAJrMBkNrCguG4fCK5QtZjARPti7LnL5chsSuD=Sg@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

> > While looking it at I found a bug.  It returns the second column
> > in wrong order when both of the distance functions return recheck = true.
> > Test script attached to run on the regression database.  I tried to
> > fix but could not.  searchTreeItemDistanceRecheck function is not
> > very easy to follow.  I think it deserves more comments.
> 
> Fixed, thanks. It was logical error in comparison function implementation.

I managed to break it again by ordering rows only by the second column
of the index.  Test script attached.

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Attachments:

  knn-gist-recheck-test-secondcolumn.sql (application/x-sql, 1.1K) download

view thread (42+ messages)  latest in thread

Message-ID: <20140917081250.GA28651@hasegeli.com>
Permalink:  ../20140917081250.GA28651@hasegeli.com/
Also on:    postgresql.org/message-id/20140917081250.GA28651@hasegeli.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: emre@hasegeli.com, aekorotkov@gmail.com, hlinnakangas@vmware.com
  Subject: Re: KNN-GiST with recheck
  In-Reply-To: <20140917081250.GA28651@hasegeli.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox