From: Stephen Frost <sfrost@snowman.net>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Mark Kirkwood <mark.kirkwood@catalyst.net.nz>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Cc: Haribabu Kommi <kommi.haribabu@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: Per table autovacuum vacuum cost limit behaviour strange
Date: Thu, 2 Oct 2014 11:03:36 -0400
Message-ID: <20141002150336.GO28859@tamriel.snowman.net> (raw)
In-Reply-To: <CA+TgmobQokthgWmv1C9vjvpz=K9koovy6O+nWZ9rV8gwC8ioRw@mail.gmail.com>
References: <CAJrrPGeEwsezwA6+DpA2Y7MBJmEnNWwD5Gi4Ve_EqCxHoyHj3Q@mail.gmail.com>
<CAA4eK1LwFs9iM-rUdfOrZE5MvjSxMM9ZbPbzv1SeWgGYu-O=VQ@mail.gmail.com>
<53672F63.3080400@catalyst.net.nz>
<CAA4eK1KDAUP=g59ku_0ekDoRjaGfEamyadQn5rJVt3j5oErLXg@mail.gmail.com>
<53686F22.8030300@catalyst.net.nz>
<20140826161911.GE6343@eldon.alvh.no-ip.org>
<CA+Tgmoav37msTP0pVsrEYz4LBYU6SETMZGYTgPo5AEOC0yCMbA@mail.gmail.com>
<20140930221644.GR5311@eldon.alvh.no-ip.org>
<20141002135412.GX5311@eldon.alvh.no-ip.org>
<CA+TgmobQokthgWmv1C9vjvpz=K9koovy6O+nWZ9rV8gwC8ioRw@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
* Robert Haas (robertmhaas@gmail.com) wrote:
> On Thu, Oct 2, 2014 at 9:54 AM, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
> > Alvaro Herrera wrote:
> >> So in essence what we're going to do is that the balance mechanism
> >> considers only tables that don't have per-table configuration options;
> >> for those that do, we will use the values configured there without any
> >> changes.
> >>
> >> I'll see about implementing this and making sure it finds its way to
> >> 9.4beta3.
> >
> > Here's a patch that makes it work as proposed.
> >
> > How do people feel about back-patching this? On one hand it seems
> > there's a lot of fear of changing autovacuum behavior in back branches,
> > because for many production systems it has carefully been tuned; on the
> > other hand, it seems hard to believe that anyone has tuned the system to
> > work sanely given how insanely per-table options behave in the current
> > code.
>
> I agree with both of those arguments. I have run into very few
> customers who have used the autovacuum settings to customize behavior
> for particular tables, and anyone who hasn't should see no change
> (right?), so my guess is that the practical impact of the change will
> be pretty limited. On the other hand, it's a clear behavior change.
> Someone could have set the per-table limit to something enormous and
> never suffered from that setting because it has basically no effect as
> things stand right now today; and that person might get an unpleasant
> surprise when they update.
>
> I would at least back-patch it to 9.4. I could go either way on
> whether to back-patch into older branches. I lean mildly in favor of
> it at the moment, but with considerable trepidation.
I'm fine with putting it into 9.4. I'm not sure that I see the value in
changing the back-branches and then having to deal with the "well, if
you're on 9.3.5 then X, but if you're on 9.3.6 then Y" or having to
figure out how to deal with the documentation for this.
Has there been any thought as to what pg_upgrade should do..?
Thanks,
Stephen
Attachments:
signature.asc (application/pgp-signature, 818B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: sfrost@snowman.net, robertmhaas@gmail.com, alvherre@2ndquadrant.com, mark.kirkwood@catalyst.net.nz, amit.kapila16@gmail.com, kommi.haribabu@gmail.com
Subject: Re: Per table autovacuum vacuum cost limit behaviour strange
In-Reply-To: <20141002150336.GO28859@tamriel.snowman.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox