From: Bruce Momjian <bruce@momjian.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Stefan Kaltenbrunner <stefan@kaltenbrunner.cc>
Cc: David Fetter <david@fetter.org>
Cc: Michael Paquier <michael.paquier@gmail.com>
Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Subject: Re: Updating copyright notices to 2015 for PGDG
Date: Tue, 6 Jan 2015 16:16:56 -0500
Message-ID: <20150106211656.GC17824@momjian.us> (raw)
In-Reply-To: <20150106211230.GR1457@alvh.no-ip.org>
References: <CAB7nPqSx0TzRz_0+t1oZXTrFns5ztKi6X4Zyh06tq7vvO2Qkng@mail.gmail.com>
<20150103214537.GF26414@fetter.org>
<20150106151917.GB13684@momjian.us>
<54AC3B8B.2020902@kaltenbrunner.cc>
<20150106205411.GB17824@momjian.us>
<20150106211230.GR1457@alvh.no-ip.org>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
On Tue, Jan 6, 2015 at 06:12:30PM -0300, Alvaro Herrera wrote:
> Bruce Momjian wrote:
> > On Tue, Jan 6, 2015 at 08:46:19PM +0100, Stefan Kaltenbrunner wrote:
> > > > I will run the script today. I didn't do it earlier because I want to
> > > > be current on reading community email before doing it.
> > >
> > > hmm is it intentional that the commit also changed other files?
> > >
> > > looks like the commited patch added newlines to various files that had
> > > none before for example:
> >
> > Specifically, these files had no newline after the last line in the
> > file.
>
> I don't think we have any files that require not to have a trailing
> newline. Do we need an explicit check against it? Seems doubtful, but
> then if the need arises, we will break it each year and who knows if
> anybody will be vigilant enough to notice. Stefan caught it this time,
> but who would normally skim 18000 lines of supposedly mechanical diff
> looking for issues? (How did you catch this in the first place?)
I am guessing pgindent would also add a newline, but since the spec
files aren't C files, pgindent doesn't tough them.
> This makes me wonder however how wise it is to update the copyright
> notices in every single file in the repo. Why do we need this? Why not
> abolish the practice and live forever with most files having copyright
> 2015? (Only new files would have newer years in their copyright
> notices, I guess.) Does this provide us with any kind of protection,
> and if so against what, and how does it protect us? Since we have a
> very clean git history which shows us the exact provenance of every
> single line of source code, and we have excellent mail archives that
> show where each line came from for all development in the last decade,
> this single line of (C) boilerplate in each file seems completely
> pointless.
I think the copyright update is more of a consistency thing, rather than
something that has a legal requirement. It is hard to see why we would
stop doing it just to preserve missing trailing newlines we don't even
know we need.
--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: bruce@momjian.us, alvherre@2ndquadrant.com, stefan@kaltenbrunner.cc, david@fetter.org, michael.paquier@gmail.com
Subject: Re: Updating copyright notices to 2015 for PGDG
In-Reply-To: <20150106211656.GC17824@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox