From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Noah Misch <noah@leadboat.com>
Cc: Peter Geoghegan <pg@heroku.com>
Cc: Simon Riggs <simon@2ndquadrant.com>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: Andres Freund <andres@anarazel.de>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: Restore-reliability mode
Date: Mon, 27 Jul 2015 11:12:31 -0300
Message-ID: <20150727141231.GE5596@postgresql.org> (raw)
In-Reply-To: <20150726072645.GF1452488@tornado.leadboat.com>
References: <CA+TgmoYovkev0xXnxaTD8vnt=M9Cn+RmOkVEouqwj6_9JLkzLw@mail.gmail.com>
<20150530154559.GA25053@momjian.us>
<20150530204727.GJ13944@alap3.anarazel.de>
<20150531024845.GB13697@momjian.us>
<20150603135049.GA74753@tornado.leadboat.com>
<CANP8+jJgKpBac77b77xLWTxxBeq9hG3a0uY-JUv6F4k=2=Nsgw@mail.gmail.com>
<20150606195805.GA118899@tornado.leadboat.com>
<CAM3SWZT9tHNDj4Q0-=tcYiEtBHZteCF-=0_B=LddQ18c8qA1wQ@mail.gmail.com>
<20150723195349.GW5596@postgresql.org>
<20150726072645.GF1452488@tornado.leadboat.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Noah Misch wrote:
> On Thu, Jul 23, 2015 at 04:53:49PM -0300, Alvaro Herrera wrote:
> > Peter Geoghegan wrote:
> > > On Sat, Jun 6, 2015 at 12:58 PM, Noah Misch <noah@leadboat.com> wrote:
> > > > - Call VALGRIND_MAKE_MEM_NOACCESS() on a shared buffer when its local pin
> > > > count falls to zero. Under CLOBBER_FREED_MEMORY, wipe a shared buffer
> > > > when its global pin count falls to zero.
> > >
> > > Did a patch for this ever materialize?
> >
> > I think the first part would be something like the attached.
>
> Neat. Does it produce any new complaints during "make installcheck"?
I only tried a few tests, for lack of time, and it didn't produce any.
(To verify that the whole thing was working properly, I reduced the
range of memory made available during PinBuffer and that resulted in a
crash immediately). I am not really familiar with valgrind TBH and just
copied a recipe to run postmaster under it, so if someone with more
valgrind-fu could verify this, it would be great.
This part:
> > > > Under CLOBBER_FREED_MEMORY, wipe a shared buffer when its
> > > > global pin count falls to zero.
can be done without any valgrind, I think. Any takers?
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, noah@leadboat.com, pg@heroku.com, simon@2ndquadrant.com, bruce@momjian.us, andres@anarazel.de, robertmhaas@gmail.com, tgl@sss.pgh.pa.us, sfrost@snowman.net, magnus@hagander.net
Subject: Re: Restore-reliability mode
In-Reply-To: <20150727141231.GE5596@postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox