pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Josh Berkus <josh@agliodbs.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: pgbench stats per script & other stuff
Date: Thu, 3 Sep 2015 11:11:22 +0200
Message-ID: <20150903091122.GA23957@awork2.anarazel.de> (raw)
In-Reply-To: <alpine.DEB.2.10.1509022002110.21677@sto>
References: <55AFD8C6.8010507@agliodbs.com>
	<CA+TgmobZSBmWzugAQp94=q98c2fmSBc+gRPwfNM+94dhjpL3tg@mail.gmail.com>
	<alpine.DEB.2.10.1507231759400.10585@sto>
	<CA+TgmoZEvNJ8wkVdHCsWnsz8Rz-MHebGp4DY+8WjiU-xYPT6Nw@mail.gmail.com>
	<alpine.DEB.2.10.1507250910540.20046@sto>
	<alpine.DEB.2.10.1507251618230.25082@sto>
	<alpine.DEB.2.10.1507281626330.3538@sto>
	<alpine.DEB.2.10.1507301801500.22793@sto>
	<20150902172617.GJ5286@alap3.anarazel.de>
	<alpine.DEB.2.10.1509022002110.21677@sto>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

On 2015-09-02 20:20:45 +0200, Fabien COELHO wrote:
> >>+static SQLScript sql_script[MAX_SCRIPTS];
> >>
> >>+static struct {
> >>+	char *name;   /* very short name for -b ...*/
> >>+	char *desc;   /* short description */
> >>+	char *script; /* actual pgbench script */
> >>+} builtin_script[]
> >
> >Can't we put these in the same array?
> 
> I do not understand.

Right now builtins and user defined scripts are stored in different data
structures. I'd rather see them in the same.

Greetings,

Andres Freund


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (92+ messages)  latest in thread

Message-ID: <20150903091122.GA23957@awork2.anarazel.de>
Permalink:  ../20150903091122.GA23957@awork2.anarazel.de/
Also on:    postgresql.org/message-id/20150903091122.GA23957@awork2.anarazel.de

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: andres@anarazel.de, coelho@cri.ensmp.fr, robertmhaas@gmail.com, josh@agliodbs.com
  Subject: Re: pgbench stats per script & other stuff
  In-Reply-To: <20150903091122.GA23957@awork2.anarazel.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox